Fix OutgoingIntegrationRequestsTimeout config key name and default value#8943
Fix OutgoingIntegrationRequestsTimeout config key name and default value#8943mgdelacroix wants to merge 6 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR corrects the Mattermost documentation for the “Integration request timeout” setting by aligning the documented config.json key name, environment variable name, and default value with the actual server configuration behavior.
Changes:
- Fixes the documented
config.jsonkey fromOutgoingIntegrationRequestsDefaultTimeouttoOutgoingIntegrationRequestsTimeout. - Fixes the documented environment variable to
MM_SERVICESETTINGS_OUTGOINGINTEGRATIONREQUESTSTIMEOUT. - Updates the documented default timeout from 3 seconds to 30 seconds, including the inline
config.jsonexample.
|
Newest code from mattermost has been published to preview environment for Git SHA a80a826 |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
Newest code from mattermost has been published to preview environment for Git SHA fe96543 |
|
Newest code from mattermost has been published to preview environment for Git SHA ec7bb2e |
|
Newest code from mattermost has been published to preview environment for Git SHA 0313516 |
|
@angeloskyratzakos - Can you help give this one a technical review when you're able? Thanks so much in advance! |
|
Newest code from mattermost has been published to preview environment for Git SHA 1e4e40e |
|
Newest code from mattermost has been published to preview environment for Git SHA 1110665 |
Summary
Fixes three errors in the Integration request timeout config setting documentation:
:configjson:wasOutgoingIntegrationRequestsDefaultTimeout— this is the name of an internal Go constant, not theconfig.jsonkey. The correct key isOutgoingIntegrationRequestsTimeout.:environment:wasMM_SERVICESETTINGS_OUTGOINGINTEGRATIONREQUESTDEFAULTTIMEOUT(derived from the wrong key). Corrected toMM_SERVICESETTINGS_OUTGOINGINTEGRATIONREQUESTSTIMEOUT.3seconds. The actual default is30seconds (set inconfig.SetDefaults, enforced byIsValidwhich rejects<= 0).Ticket Link
https://mattermost.atlassian.net/browse/MM-68319