Document plugin-provided metrics at the standard /metrics endpoint#9038
Document plugin-provided metrics at the standard /metrics endpoint#9038Combs7th wants to merge 3 commits into
Conversation
…9029) * Remove CJK search feature flag mention now that it defaults to true * Clarify CJK search defaults to true on v11.9, flag-gated on v11.5-v11.8 * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Add documentation for the AggregatePluginMetrics feature flag (v11.8.0), which exposes plugin-provided Prometheus metrics through the standard Mattermost /metrics endpoint with a plugin_id label. Co-authored-by: Combs7th <Combs7th@users.noreply.github.com>
📝 WalkthroughWalkthroughThis documentation update explains how system administrators can collect plugin-provided Prometheus metrics through Mattermost's standard ChangesPlugin Metrics Feature Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
source/administration-guide/scale/deploy-prometheus-grafana-for-performance-monitoring.rst (1)
125-125: 💤 Low valueConsider adding version information for consistency and clarity.
While this segment accurately describes the feature flag and aggregation behavior, it does not mention the Mattermost version (v11.8.0). The parallel documentation in
performance-monitoring-metrics.rst(line 179) explicitly states "From Mattermost v11.8.0," which helps admins identify feature availability. Adding the version here would improve consistency across the documentation and align with the PR objectives to use versioned wording.Optional improvement (not required):
-When the ``AggregatePluginMetrics`` feature flag is enabled, plugin-provided metrics are included in the same ``/metrics`` scrape target and can be filtered by the ``plugin_id`` label. +From Mattermost v11.8.0, when the ``AggregatePluginMetrics`` feature flag is enabled, plugin-provided metrics are included in the same ``/metrics`` scrape target and can be filtered by the ``plugin_id`` label.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@source/administration-guide/scale/deploy-prometheus-grafana-for-performance-monitoring.rst` at line 125, The sentence about the AggregatePluginMetrics feature flag should include the version it was introduced in for consistency: update the line mentioning "AggregatePluginMetrics", "/metrics" and the "plugin_id" label to begin with "From Mattermost v11.8.0," (or otherwise append the version phrase) so it reads similarly to the parallel note in performance-monitoring-metrics.rst and clearly communicates feature availability.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@source/administration-guide/scale/performance-monitoring-metrics.rst`:
- Around line 181-182: Replace the existing ``.. note::`` admonition with ``..
important::`` for the line that states "``AggregatePluginMetrics`` is disabled
by default and must be enabled before plugin-provided metrics are included in
the ``/metrics`` response" so the prerequisite constraint
(AggregatePluginMetrics) is elevated to an important admonition; locate the text
mentioning AggregatePluginMetrics in performance-monitoring-metrics.rst and
change the directive from ``.. note::`` to ``.. important::`` while keeping the
quoted message content unchanged.
---
Nitpick comments:
In
`@source/administration-guide/scale/deploy-prometheus-grafana-for-performance-monitoring.rst`:
- Line 125: The sentence about the AggregatePluginMetrics feature flag should
include the version it was introduced in for consistency: update the line
mentioning "AggregatePluginMetrics", "/metrics" and the "plugin_id" label to
begin with "From Mattermost v11.8.0," (or otherwise append the version phrase)
so it reads similarly to the parallel note in performance-monitoring-metrics.rst
and clearly communicates feature availability.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 98b74263-7a48-42c2-ab3c-236486c169d4
📒 Files selected for processing (2)
source/administration-guide/scale/deploy-prometheus-grafana-for-performance-monitoring.rstsource/administration-guide/scale/performance-monitoring-metrics.rst
|
Newest code from mattermost has been published to preview environment for Git SHA 1f33365 |
|
@cpoile - Would you say the above doc updates would suffice? |
|
Newest code from mattermost has been published to preview environment for Git SHA 0f574e2 |
|
@wiersgallak - This one will need editor review as well after dev review is complete. |
Documents that, from Mattermost v11.8.0, plugin-provided Prometheus metrics can be exposed through the standard
/metricsendpoint when theAggregatePluginMetricsfeature flag is enabled. Aggregated metrics carry aplugin_idlabel.Resolves #9034
Generated with Claude Code