Skip to content

Add FFD rule of thumb tip to mach aero tutorial and clean up some for…#173

Open
gawng wants to merge 3 commits intomainfrom
ffd-patch
Open

Add FFD rule of thumb tip to mach aero tutorial and clean up some for…#173
gawng wants to merge 3 commits intomainfrom
ffd-patch

Conversation

@gawng
Copy link
Copy Markdown
Collaborator

@gawng gawng commented Apr 2, 2025

Purpose

Some people ask how many FFDs is a good amount. This rule of thumb was not written anywhere.
Also formatting stuff

Expected time until merged

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@gawng gawng requested a review from a team as a code owner April 2, 2025 22:36
@gawng gawng requested review from anilyil and hajdik April 2, 2025 22:36
anilyil
anilyil previously approved these changes Apr 4, 2025
@hajdik
Copy link
Copy Markdown
Contributor

hajdik commented Apr 30, 2025

I noticed function names weren't linked to the info in the docs so @gawng and I talked about adding them for this page so it's easier to find API information. I added all of the links except for write_wing_FFD_file() which I couldn't get to work.

@hajdik hajdik removed their request for review April 30, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants