Update note to explain what domain is referred by pyhyp index#177
Open
DavidAnderegg wants to merge 1 commit intomdolab:mainfrom
Open
Update note to explain what domain is referred by pyhyp index#177DavidAnderegg wants to merge 1 commit intomdolab:mainfrom
DavidAnderegg wants to merge 1 commit intomdolab:mainfrom
Conversation
Contributor
|
Hi @DavidAnderegg , thanks for the change. Unfortunately, it's more complicated than that. I think Pointwise has a separate sorting that you can prescribe. However, from my understanding, it is the CGNS format that sorts things using the "lexicographical" order. So whatever output order you pick in Pointwise is overwritten in CGNS. We sort in Pointwise by name because that is the closest thing. Maybe update the docs to represent this? |
Contributor
Author
|
Hi @anilyil, thats basically what i write in the changes...? Maybe you ask me to make it more explicit? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Documentation update as there is a better way than 'trial and error' to figure out what index a domain in Pointwise is referred to in pyHyp.
Expected time until merged
When you have time.
Type of change
Testing
none
Checklist
flake8andblackto make sure the Python code adheres to PEP-8 and is consistently formattedfprettifyor C/C++ code withclang-formatas applicable