ci: add cross-platform validation for Linux, macOs, and Windows#134
Closed
slyt3 wants to merge 2 commits intomemodb-io:mainfrom
Closed
ci: add cross-platform validation for Linux, macOs, and Windows#134slyt3 wants to merge 2 commits intomemodb-io:mainfrom
slyt3 wants to merge 2 commits intomemodb-io:mainfrom
Conversation
Contributor
Author
Contributor
|
hey @slyt3 , you open this pr to validate CLI, but cli code is in |
Contributor
Author
|
Hey thanks, my mistake haha, i will update the working dir in the CI to point to src/client/acontext-cli right now, it will ensure we are validate the correct layer, I Will push the fix soon |
Contributor
|
Thanks for the suggestion! However, we already have cross-platform validation covered in our existing Cross-platform build (lines 100-148):
Testing with race detector (lines 22-65):
Additional features the current workflow provides:
Adding a separate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Github Action workflow to ensure the acontext CLI remains stable across diff operating systems
so while implementing disk features (grep,glob) I noticed the need to verify file-system logic on non-Linux env.
This Pipeline automates that process
Key changes
-raceflag that will catch concurrency bugs early.src/server/api/go) to ensure fast executionSo this would and will act a quality gate for my pending PR and all future contributions