Conversation
…sing Suspense boundaries Sync the active tab (metadata/skills/sessions) in the Learning Space detail page with a ?tab= URL search parameter. Also add Suspense boundaries around all client components that use useSearchParams to follow Next.js App Router best practices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why we need this PR?
Learning Space detail page tabs (metadata/skills/sessions) are not reflected in the URL, so users can't bookmark or share links to a specific tab. Also, several client components using
useSearchParamslack<Suspense>boundaries, which triggers Next.js SSR warnings.Describe your solution
useStateforactiveTabwithuseSearchParams/usePathnameso the active tab is read from?tab=and updated viarouter.replace. Default tab isskills(no param needed).useSearchParamswith<Suspense>to follow Next.js App Router requirements.Implementation Tasks
?tab=URL search param<Suspense>toproject/[id]/session/page.tsx<Suspense>toproject/[id]/session/[sessionId]/task/page.tsx<Suspense>toproject/[id]/learning-spaces/page.tsx<Suspense>toproject/[id]/learning-spaces/[spaceId]/page.tsx<Suspense>toproject/[id]/disk/page.tsx<Suspense>tonew/[id]/page.tsx<Suspense>tonew/page.tsx(extracted inner component)<Suspense>toauth/layout.tsx(wraps login page children)Impact Areas
Checklist
devbranch.