fix linker args for lld-link + clang-cl + flang#15660
Open
lucascolley wants to merge 1 commit intomesonbuild:masterfrom
Open
fix linker args for lld-link + clang-cl + flang#15660lucascolley wants to merge 1 commit intomesonbuild:masterfrom
lld-link + clang-cl + flang#15660lucascolley wants to merge 1 commit intomesonbuild:masterfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
c056aad to
b548178
Compare
flang + clang-clflang + clang-cl + lld-link
flang + clang-cl + lld-linklld-link + clang-cl + flang
5 tasks
b548178 to
7387532
Compare
7387532 to
edb6f29
Compare
Author
|
This fix is for the following rule: On this PR: On the latest release: |
lucascolley
commented
Mar 29, 2026
| return args | ||
|
|
||
| def get_build_link_args(self, target: BuildTarget, build: Build) -> T.List[str]: | ||
| return self._sanitize_linker_args(super().get_build_link_args(target, build)) |
Author
There was a problem hiding this comment.
this is called at
meson/mesonbuild/backend/ninjabackend.py
Line 3793 in 2ab0228
lld-link when using it with clang-cl. Hence, we want the same stripping of -Wl, as occurs at meson/mesonbuild/compilers/mixins/clike.py
Line 404 in 2ab0228
build_wrapper_args.
Author
|
cc @bonzini I see you have worked on this file recently :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes scipy/scipy#24925 (in combination with conda-forge/flang-activation-feedstock#51).
I have been unable to find a way to craft
LDFLAGSsuch that bothclang-clandflangingest them without warnings when usinglld-link. This PR aims to fix that by stripping-Wl,when the ninja backend grabsLINK_ARGS.