Merge C++, ObjC language arguments#15766
Draft
kode54 wants to merge 1 commit into
Draft
Conversation
...in Xcode build targets.
From the original author:
I ran into an issue trying to compile lc0 (Leela Chess Zero
engine) with Meson where a compiler option -DNO_PEXT was not
being passed to clang. This was because the lc0@exe target
had both cpp, objc languages and the latter language's project
arguments were overriding the cpp language options. I'm assuming
that since objc options are set as cpp options, the options for
both languages need to be merged. After doing this, the Xcode
build for lc0 succeeds.
Co-authored-by: Shukant Pal <SukantK2002@outlook.com>
Signed-off-by: Christopher Snowhill <kode54@gmail.com>
Author
|
This may not be a correct approach. I noticed it paired with the other PR, but didn't test it first, since it looked so simple in design. I guess it's incorrect after all. I'll re-evaluate it later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...in Xcode build targets.
From the original author:
Again, following up after the original submitter apparently rage-quit.