Silentpush-final-code

[karand-metron]

Silentpush-final-code

[yash-metron]

Instead of checking like this let's add :-
base_url = demisto.params().get('url', 'https://api.silentpush.com') if url_suffix.startswith("/api/v2/") else self.base_url
full_url = f'{base_url}{url_suffix}'

[yash-metron]

Implement the above logic and remove these lines.

[yash-metron]

In this parse_subject() function remove redundant elif, first if returns early, the next check doesn’t need elif; a simple if is cleaner.

[yash-metron]

Create a seperate class for these type of functions. Name it as a Helper class and add this function in that.
Also create a single function for both ipv4 and ipv6 to validate them. Use is_ipv6_valid() and is_ip_valid() for the validation check. Refer to this doc

[yash-metron]

Ensure response is a dictionary and check status code

Suggested change

	if resp.get("status_code") != 200:
	if not isinstance(resp, dict) or resp.get("status_code") != 200:

[yash-metron]

Create a separate function to format domain information into markdown tables.

def _format_domain_info(domains_data: List[Dict[str, Any]], fetch_risk_score: bool, fetch_whois_info: bool) -> str:
    """Formats domain information into markdown tables."""
    markdown = ["# Domain Information Results\n"]

    for domain_data in domains_data:
        domain = domain_data.get("domain", "N/A")
        markdown.append(f"## Domain: {domain}")

        basic_info = {
            "Created Date": domain_data.get("whois_created_date", "N/A"),
            "Updated Date": domain_data.get("whois_updated_date", "N/A"),
            "Expiration Date": domain_data.get("whois_expiration_date", "N/A"),
            "Registrar": domain_data.get("registrar", "N/A"),
            "Status": domain_data.get("status", "N/A"),
            "Name Servers": domain_data.get("nameservers", "N/A"),
        }
        markdown.append(tableToMarkdown("Domain Information", [basic_info]))

        if fetch_risk_score:
            risk_info = {
                "Risk Score": domain_data.get("risk_score", "N/A"),
                "Risk Score Explanation": domain_data.get("risk_score_explanation", "N/A"),
            }
            markdown.append(tableToMarkdown("Risk Assessment", [risk_info]))

        if fetch_whois_info:
            whois_info = domain_data.get("whois_info", {})
            if whois_info:
                if "error" in whois_info:
                    markdown.append(f"**WHOIS Error:** {whois_info['error']}")
                else:
                    markdown.append(tableToMarkdown("WHOIS Information", [whois_info]))

        markdown.append("\n---\n")

    return "\n".join(markdown)

[yash-metron]

Suggested change

	response = client.list_domain_information(domains, fetch_risk_score, fetch_whois_info)
	response = client.list_domain_information(domains, fetch_risk_score, fetch_whois_info)
	markdown = _format_domain_info(response.get("domains", []), fetch_risk_score, fetch_whois_info)

[yash-metron]

Suggested change

	infratags = raw_response.get('response', {}).get('infratags', [])
	tag_clusters = raw_response.get('response', {}).get('tag_clusters', [])
	iresponse_data = raw_response.get('response', {})
	infratags = response_data.get('infratags', [])
	tag_clusters = response_data.get('tag_clusters', [])

[yash-metron]

Suggested change

	if cluster and tag_clusters:
	cluster_details = []
	for cluster in tag_clusters:
	for key, value in cluster.items():
	cluster_details.append({'Cluster Level': key, 'Details': value})
	readable_output += tableToMarkdown('Domain Tag Clusters', cluster_details)
	if cluster and not tag_clusters:
	readable_output += "\n\n**No tag cluster data returned by the API.**"
	if cluster:
	if tag_clusters:
	cluster_details = [
	{'Cluster Level': key, 'Details': value}
	for cluster in tag_clusters
	for key, value in cluster.items()
	]
	readable_output += tableToMarkdown('Domain Tag Clusters', cluster_details)
	else:
	readable_output += "\n\n**No tag cluster data returned by the API.**"