Skip to content

LEGO: Pull request from lego/hb_d72c5677-3f00-4225-b18e-0a1e8a8f5f0e_20260523095417037 to main#1566

Closed
csigs wants to merge 1 commit into
mainfrom
lego/hb_d72c5677-3f00-4225-b18e-0a1e8a8f5f0e_20260523095417037
Closed

LEGO: Pull request from lego/hb_d72c5677-3f00-4225-b18e-0a1e8a8f5f0e_20260523095417037 to main#1566
csigs wants to merge 1 commit into
mainfrom
lego/hb_d72c5677-3f00-4225-b18e-0a1e8a8f5f0e_20260523095417037

Conversation

@csigs
Copy link
Copy Markdown
Member

@csigs csigs commented May 23, 2026

LEGO: Pull request from lego/hb_d72c5677-3f00-4225-b18e-0a1e8a8f5f0e_20260523095417037 to main with localized lcls

@gregg-miskelly
Copy link
Copy Markdown
Member

@WardenGnaw Looks like we localized two type fields

@WardenGnaw
Copy link
Copy Markdown
Member

@gregg-miskelly Copilot really wants us to keep it to prevent future accidental localization on the type field.
See https://github.com/microsoft/MIEngine/pull/1568/changes#r3304826953

hardwareBreakpoints did it E.g.:

<Item ItemId=";debugExtensions.cppdbg.schema.definitions.cpp_schema.definitions.hardwareBreakpointsOptions.type" ItemType="0" PsrId="306" InstFlg="true" Leaf="true">
<Str Cat="Text">
<Val><![CDATA[object]]></Val>
</Str>
<Disp Icon="Str" />
<Cmts>
<Cmt Name="LcxAdmin"><![CDATA[{Locked}]]></Cmt>
</Cmts>
</Item>
and its at least commented with ![CDATA[{Locked}]]

@gregg-miskelly
Copy link
Copy Markdown
Member

Sorry, yes, I think we need to reference it in the lci, but lock it

@WardenGnaw
Copy link
Copy Markdown
Member

Abandoning in hopes for a new PR to make the correct fixes.

@WardenGnaw WardenGnaw closed this May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants