Skip to content

[Test Improver] Add unit tests for LoggingManager.BuildAsync #8129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Evangelink merged 7 commits into from
May 14, 2026
+9 −12
Merged

[Test Improver] Add unit tests for LoggingManager.BuildAsync #8129

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fa6c1d3
test: add unit tests for LoggingManager.BuildAsync
github-actions[bot] May 3, 2026
953bd4f
Address review feedback on LoggingManagerTests
Copilot May 11, 2026
b53371b
Merge origin/main into branch to resolve conflicts
Copilot May 11, 2026
a1a53ef
Fix CS8625: cast null to (IRunSettings?) in DesktopTestSourceHostTests
Copilot May 11, 2026
24dc9a1
Merge remote-tracking branch 'origin/main' into test-assist/logging-m…
Evangelink May 13, 2026
8b4d41a
Rename enabledProvider to nonExtensionProvider for clarity
Evangelink May 13, 2026
d7f2e60
Merge origin/main - resolve LoggingManagerTests conflict
Copilot May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 26 additions & 5 deletions test/UnitTests/Microsoft.Testing.Platform.UnitTests/Logging/LoggingManagerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ public async Task BuildAsync_NonExtensionProvider_IsAlwaysIncluded()
manager.AddProvider((_, _) => mockProvider.Object);

ILoggerFactory factory = await manager.BuildAsync(_mockServiceProvider.Object, LogLevel.Information, _mockMonitor.Object);
factory.CreateLogger("test");
_ = factory.CreateLogger("test");

mockProvider.Verify(p => p.CreateLogger("test"), Times.Once);
}
Expand All @@ -85,7 +85,7 @@ public async Task BuildAsync_EnabledExtensionProvider_IsIncluded()
manager.AddProvider((_, _) => mockProvider.Object);

ILoggerFactory factory = await manager.BuildAsync(_mockServiceProvider.Object, LogLevel.Information, _mockMonitor.Object);
factory.CreateLogger("test");
_ = factory.CreateLogger("test");

mockProvider.Verify(p => p.CreateLogger("test"), Times.Once);
}
Expand All @@ -99,7 +99,7 @@ public async Task BuildAsync_DisabledExtensionProvider_IsExcluded()
manager.AddProvider((_, _) => mockProvider.Object);

ILoggerFactory factory = await manager.BuildAsync(_mockServiceProvider.Object, LogLevel.Information, _mockMonitor.Object);
factory.CreateLogger("test");
_ = factory.CreateLogger("test");

mockProvider.Verify(p => p.CreateLogger(It.IsAny<string>()), Times.Never);
}
Expand All @@ -115,7 +115,7 @@ public async Task BuildAsync_InitializableExtensionProvider_WhenEnabled_CallsIni
manager.AddProvider((_, _) => mockProvider.Object);

ILoggerFactory factory = await manager.BuildAsync(_mockServiceProvider.Object, LogLevel.Information, _mockMonitor.Object);
factory.CreateLogger("test");
_ = factory.CreateLogger("test");

mockProvider.Verify(p => p.InitializeAsync(), Times.Once);
mockProvider.Verify(p => p.CreateLogger("test"), Times.Once);
Expand Down Expand Up @@ -144,11 +144,32 @@ public async Task BuildAsync_NonExtensionInitializableProvider_CallsInitializeAs
manager.AddProvider((_, _) => mockProvider.Object);

ILoggerFactory factory = await manager.BuildAsync(_mockServiceProvider.Object, LogLevel.Information, _mockMonitor.Object);
factory.CreateLogger("test");
_ = factory.CreateLogger("test");

mockProvider.Verify(p => p.InitializeAsync(), Times.Once);
Comment thread
Evangelink marked this conversation as resolved.
mockProvider.Verify(p => p.CreateLogger("test"), Times.Once);
}

[TestMethod]
public async Task BuildAsync_MultipleProviders_OnlyIncludesEnabledOnes()
{
LoggingManager manager = new();

Mock<IExtensionLoggerProvider> disabledProvider = new();
disabledProvider.Setup(p => p.IsEnabledAsync()).ReturnsAsync(false);

Mock<ILoggerProvider> enabledProvider = new();
enabledProvider.Setup(p => p.CreateLogger(It.IsAny<string>())).Returns(new Mock<ILogger>().Object);

manager.AddProvider((_, _) => disabledProvider.Object);
manager.AddProvider((_, _) => enabledProvider.Object);

ILoggerFactory factory = await manager.BuildAsync(_mockServiceProvider.Object, LogLevel.Information, _mockMonitor.Object);
_ = factory.CreateLogger("test");

disabledProvider.Verify(p => p.CreateLogger(It.IsAny<string>()), Times.Never);
enabledProvider.Verify(p => p.CreateLogger("test"), Times.Once);
Comment thread
Evangelink marked this conversation as resolved.
Outdated
}
}

internal interface IExtensionLoggerProvider : ILoggerProvider, IExtension;
Expand Down
Loading