Guard MarshalByRefObject, [Serializable], and InitializeLifetimeService behind #if NETFRAMEWORK

src/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/MTPTraceLogger.cs

@@ -8,7 +8,11 @@
 namespace Microsoft.VisualStudio.TestTools.UnitTesting;
 
 [SuppressMessage("ApiDesign", "RS0030:Do not use banned APIs", Justification = "MTP logger bridge")]
-internal sealed class MTPTraceLogger : MarshalByRefObject, ITraceLogger
+internal sealed class MTPTraceLogger :
+#if NETFRAMEWORK
+    MarshalByRefObject,
+#endif
+    ITraceLogger
 {
     private readonly ILogger _logger;
 

src/Adapter/MSTest.TestAdapter/VSTestAdapter/EqtTraceLogger.cs

@@ -6,7 +6,11 @@
 
 namespace Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.VSTestAdapter;
 
-internal sealed class EqtTraceLogger : MarshalByRefObject, ITraceLogger
+internal sealed class EqtTraceLogger :
+#if NETFRAMEWORK
+    MarshalByRefObject,
+#endif
+    ITraceLogger
 {
     private EqtTraceLogger()
     {

src/Adapter/MSTestAdapter.PlatformServices/Deployment/DeploymentItem.cs

@@ -10,7 +10,9 @@ namespace Microsoft.VisualStudio.TestPlatform.MSTestAdapter.PlatformServices.Dep
 /// <summary>
 /// Specifies type of deployment item origin, where the item comes from.
 /// </summary>
+#if NETFRAMEWORK
 [Serializable]
+#endif
 internal enum DeploymentItemOriginType
 {
     /// <summary>
@@ -37,7 +39,9 @@ internal enum DeploymentItemOriginType
 /// <summary>
 /// The deployment item for a test class or a test method.
 /// </summary>
+#if NETFRAMEWORK
 [Serializable]
+#endif
 internal sealed class DeploymentItem
 {
     /// <summary>

src/Adapter/MSTestAdapter.PlatformServices/Deployment/TestRunDirectories.cs

@@ -10,7 +10,9 @@ namespace Microsoft.VisualStudio.TestPlatform.MSTestAdapter.PlatformServices.Dep
 /// <summary>
 /// The test run directories.
 /// </summary>
+#if NETFRAMEWORK
 [Serializable]
+#endif
 internal sealed class TestRunDirectories
 {
     /// <summary>

src/Adapter/MSTestAdapter.PlatformServices/Discovery/AssemblyEnumerationResult.cs

@@ -10,5 +10,7 @@ namespace Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.Discovery;
 /// </summary>
 /// <param name="TestElements">The test elements that were discovered.</param>
 /// <param name="Warnings">Warnings that happened during discovery.</param>
+#if NETFRAMEWORK
 [Serializable]
+#endif
 internal sealed record AssemblyEnumerationResult(List<UnitTestElement> TestElements, List<string> Warnings);

src/Adapter/MSTestAdapter.PlatformServices/Discovery/AssemblyEnumerator.cs

@@ -2,7 +2,9 @@
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
 using System.Runtime.Serialization;
+#if NETFRAMEWORK
 using System.Security;
+#endif
 
 using Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.Execution;
 using Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.Helpers;
@@ -16,7 +18,10 @@ namespace Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.Discovery;
 /// Enumerates through all types in the assembly in search of valid test methods.
 /// </summary>
 [SuppressMessage("Performance", "CA1852: Seal internal types", Justification = "Overrides required for testability")]
-internal class AssemblyEnumerator : MarshalByRefObject
+internal class AssemblyEnumerator
+#if NETFRAMEWORK
+    : MarshalByRefObject
+#endif
 {
     /// <summary>
     /// Helper for reflection API's.
@@ -45,17 +50,16 @@ public AssemblyEnumerator(MSTestSettings settings) =>
         // This would just be resetting the settings to itself in non desktop workflows.
         MSTestSettings.PopulateSettings(settings);
 
+#if NETFRAMEWORK
     /// <summary>
     /// Returns object to be used for controlling lifetime, null means infinite lifetime.
     /// </summary>
     /// <returns>
     /// The <see cref="object"/>.
     /// </returns>
     [SecurityCritical]
-#if NET5_0_OR_GREATER
-    [Obsolete("MarshalByRefObject.InitializeLifetimeService is obsolete in .NET 5+. This override is required to maintain infinite lifetime service.")]
-#endif
     public override object InitializeLifetimeService() => null!;
+#endif
 
     /// <summary>
     /// Enumerates through all types in the assembly in search of valid test methods.

src/Adapter/MSTestAdapter.PlatformServices/Execution/TestAssemblySettingsProvider.cs

@@ -1,27 +1,31 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
+#if NETFRAMEWORK
 using System.Security;
+#endif
 
 using Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.Helpers;
 using Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.ObjectModel;
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 
 namespace Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.Execution;
 
-internal sealed class TestAssemblySettingsProvider : MarshalByRefObject
+internal sealed class TestAssemblySettingsProvider
+#if NETFRAMEWORK
+    : MarshalByRefObject
+#endif
 {
+#if NETFRAMEWORK
     /// <summary>
     /// Returns object to be used for controlling lifetime, null means infinite lifetime.
     /// </summary>
     /// <returns>
     /// The <see cref="object"/>.
     /// </returns>
     [SecurityCritical]
-#if NET5_0_OR_GREATER
-    [Obsolete("MarshalByRefObject.InitializeLifetimeService is obsolete in .NET 5+. This override is required to maintain infinite lifetime service.")]
-#endif
     public override object InitializeLifetimeService() => null!;
+#endif
 
     [SuppressMessage(
         "Performance",

src/Adapter/MSTestAdapter.PlatformServices/Execution/TestExecutionManager.cs

@@ -21,7 +21,11 @@ namespace Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.Execution;
 #pragma warning disable CA1852 // Seal internal types - This class is inherited in tests.
 internal class TestExecutionManager
 {
-    private sealed class RemotingMessageLogger : MarshalByRefObject, IMessageLogger
+    private sealed class RemotingMessageLogger :
+#if NETFRAMEWORK
+        MarshalByRefObject,
+#endif
+        IMessageLogger
     {
         private readonly IMessageLogger _realMessageLogger;
 

src/Adapter/MSTestAdapter.PlatformServices/Execution/TypeCache.cs

@@ -1,7 +1,9 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
+#if NETFRAMEWORK
 using System.Security;
+#endif
 
 using Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.Discovery;
 using Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.Extensions;
@@ -15,7 +17,10 @@ namespace Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.Execution;
 /// <summary>
 /// Defines type cache which reflects upon a type and cache its test artifacts.
 /// </summary>
-internal sealed class TypeCache : MarshalByRefObject
+internal sealed class TypeCache
+#if NETFRAMEWORK
+    : MarshalByRefObject
+#endif
 {
     /// <summary>
     /// Helper for reflection API's.
@@ -108,17 +113,16 @@ public IEnumerable<TestAssemblyInfo> AssemblyInfoListWithExecutableCleanupMethod
         return ResolveTestMethodInfoForDiscovery(testMethod, testClassInfo);
     }
 
+#if NETFRAMEWORK
     /// <summary>
     /// Returns object to be used for controlling lifetime, null means infinite lifetime.
     /// </summary>
     /// <returns>
     /// The <see cref="object"/>.
     /// </returns>
     [SecurityCritical]
-#if NET5_0_OR_GREATER
-    [Obsolete("MarshalByRefObject.InitializeLifetimeService is obsolete in .NET 5+. This override is required to maintain infinite lifetime service.")]
-#endif
     public override object InitializeLifetimeService() => null!;
+#endif
 
     #region ClassInfo creation and cache logic.
 

src/Adapter/MSTestAdapter.PlatformServices/Execution/UnitTestRunner.cs

@@ -1,7 +1,9 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
+#if NETFRAMEWORK
 using System.Security;
+#endif
 
 using Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.Extensions;
 using Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.Helpers;
@@ -18,7 +20,10 @@ namespace Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.Execution;
 /// <summary>
 /// The runner that runs a single unit test. Also manages the assembly and class cleanup methods at the end of the run.
 /// </summary>
-internal sealed class UnitTestRunner : MarshalByRefObject
+internal sealed class UnitTestRunner
+#if NETFRAMEWORK
+    : MarshalByRefObject
+#endif
 {
     private readonly TypeCache _typeCache;
     private readonly ClassCleanupManager _classCleanupManager;
@@ -75,17 +80,16 @@ public void Cancel()
         => PlatformServiceProvider.Instance.TestRunCancellationToken?.Cancel();
 #pragma warning restore CA1822 // Mark members as static
 
+#if NETFRAMEWORK
     /// <summary>
     /// Returns object to be used for controlling lifetime, null means infinite lifetime.
     /// </summary>
     /// <returns>
     /// The <see cref="object"/>.
     /// </returns>
     [SecurityCritical]
-#if NET5_0_OR_GREATER
-    [Obsolete("MarshalByRefObject.InitializeLifetimeService is obsolete in .NET 5+. This override is required to maintain infinite lifetime service.")]
-#endif
     public override object InitializeLifetimeService() => null!;
+#endif
 
     // Task cannot cross app domains.
     // For now, TestExecutionManager will call this sync method which is hacky.

src/Adapter/MSTestAdapter.PlatformServices/Helpers/ReflectHelper.cs

@@ -1,15 +1,20 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
+#if NETFRAMEWORK
 using System.Security;
+#endif
 
 using Microsoft.VisualStudio.TestPlatform.ObjectModel;
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 
 namespace Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.Helpers;
 
 [SuppressMessage("Performance", "CA1852: Seal internal types", Justification = "Overrides required for mocking")]
-internal class ReflectHelper : MarshalByRefObject
+internal class ReflectHelper
+#if NETFRAMEWORK
+    : MarshalByRefObject
+#endif
 {
 #pragma warning disable RS0030 // Do not use banned APIs
     private static readonly Lazy<ReflectHelper> InstanceValue = new(() => new());
@@ -53,17 +58,16 @@ internal class ReflectHelper : MarshalByRefObject
         return false;
     }
 
+#if NETFRAMEWORK
     /// <summary>
     /// Returns object to be used for controlling lifetime, null means infinite lifetime.
     /// </summary>
     /// <returns>
     /// The <see cref="object"/>.
     /// </returns>
     [SecurityCritical]
-#if NET5_0_OR_GREATER
-    [Obsolete("MarshalByRefObject.InitializeLifetimeService is obsolete in .NET 5+. This override is required to maintain infinite lifetime service.")]
-#endif
     public override object InitializeLifetimeService() => null!;
+#endif
 
     /// <summary>
     /// Gets first attribute that matches the type.

src/Adapter/MSTestAdapter.PlatformServices/MSTestSettings.cs

@@ -18,7 +18,9 @@
 /// <summary>
 /// Adapter Settings for the run.
 /// </summary>
+#if NETFRAMEWORK
 [Serializable]
+#endif
 internal sealed class MSTestSettings
 {
     /// <summary>
@@ -36,12 +38,12 @@
     /// <summary>
     /// Member variable for Adapter settings.
     /// </summary>
     private static MSTestSettings? s_currentSettings;
 
     /// <summary>
     /// Member variable for RunConfiguration settings.
     /// </summary>
     private static RunConfigurationSettings? s_runConfigurationSettings;
 
     /// <summary>
     /// Initializes a new instance of the <see cref="MSTestSettings"/> class.

src/Adapter/MSTestAdapter.PlatformServices/NopTraceLogger.cs

@@ -5,7 +5,11 @@
 
 namespace Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter;
 
-internal sealed class NopTraceLogger : MarshalByRefObject, ITraceLogger
+internal sealed class NopTraceLogger :
+#if NETFRAMEWORK
+    MarshalByRefObject,
+#endif
+    ITraceLogger
 {
     private NopTraceLogger()
     {

src/Adapter/MSTestAdapter.PlatformServices/ObjectModel/StackTraceInformation.cs

@@ -5,7 +5,9 @@
 
 namespace Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.ObjectModel;
 
+#if NETFRAMEWORK
 [Serializable]
+#endif
 internal sealed class StackTraceInformation
 {
     public StackTraceInformation(string stackTrace)

src/Adapter/MSTestAdapter.PlatformServices/ObjectModel/TestAssemblySettings.cs

@@ -5,7 +5,9 @@
 
 namespace Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.ObjectModel;
 
+#if NETFRAMEWORK
 [Serializable]
+#endif
 internal sealed class TestAssemblySettings
 {
     public TestAssemblySettings() => Workers = -1;

src/Adapter/MSTestAdapter.PlatformServices/ObjectModel/TestMethod.cs

@@ -13,7 +13,9 @@ namespace Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.ObjectModel;
 /// <summary>
 /// TestMethod contains information about a unit test method that needs to be executed.
 /// </summary>
+#if NETFRAMEWORK
 [Serializable]
+#endif
 internal sealed class TestMethod : ITestMethod
 {
     /// <summary>

src/Adapter/MSTestAdapter.PlatformServices/ObjectModel/UnitTestElement.cs

@@ -11,7 +11,9 @@ namespace Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.ObjectModel;
 /// <summary>
 /// The unit test element.
 /// </summary>
+#if NETFRAMEWORK
 [Serializable]
+#endif
 [DebuggerDisplay("{TestMethod.DisplayName} ({TestMethod.ManagedTypeName})")]
 internal sealed class UnitTestElement
 {

src/Adapter/MSTestAdapter.PlatformServices/RecursiveDirectoryPath.cs

@@ -2,7 +2,9 @@
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
 #if !WINDOWS_UWP
+#if NETFRAMEWORK
 using System.Security;
+#endif
 
 namespace Microsoft.VisualStudio.TestPlatform.MSTestAdapter.PlatformServices;
 
@@ -18,9 +20,14 @@ namespace Microsoft.VisualStudio.TestPlatform.MSTestAdapter.PlatformServices;
 ///
 /// For each directory we need to have two info 1) path 2) includeSubDirectories.
 /// </summary>
+#if NETFRAMEWORK
 [Serializable]
+#endif
 [SuppressMessage("StyleCop.CSharp.DocumentationRules", "SA1603:DocumentationMustContainValidXml", Justification = "Reviewed. Suppression is ok here.")]
-internal sealed class RecursiveDirectoryPath : MarshalByRefObject
+internal sealed class RecursiveDirectoryPath
+#if NETFRAMEWORK
+    : MarshalByRefObject
+#endif
 {
     /// <summary>
     /// Initializes a new instance of the <see cref="RecursiveDirectoryPath"/> class.
@@ -45,16 +52,15 @@ public RecursiveDirectoryPath(string dirPath, bool includeSubDirectories)
     /// </summary>
     public bool IncludeSubDirectories { get; private set; }
 
+#if NETFRAMEWORK
     /// <summary>
     /// Returns object to be used for controlling lifetime, null means infinite lifetime.
     /// </summary>
     /// <returns>
     /// The <see cref="object"/>.
     /// </returns>
     [SecurityCritical]
-#if NET5_0_OR_GREATER
-    [Obsolete("MarshalByRefObject.InitializeLifetimeService is obsolete in .NET 5+. This override is required to maintain infinite lifetime service.")]
-#endif
     public override object InitializeLifetimeService() => null!;
+#endif
 }
 #endif

src/TestFramework/TestFramework/Attributes/TestMethod/TestResult.cs

@@ -8,7 +8,9 @@ namespace Microsoft.VisualStudio.TestTools.UnitTesting;
 /// <summary>
 /// TestResult object to be returned to adapter.
 /// </summary>
+#if NETFRAMEWORK
 [Serializable]
+#endif
 public class TestResult
 {
     /// <summary>