Skip to content

Prevent telemetry host termination on boolean MSTest setting payloads #8189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Evangelink merged 10 commits into from
May 17, 2026
+67 −3
Merged

Prevent telemetry host termination on boolean MSTest setting payloads #8189

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
22d57a7
Initial plan
Copilot May 13, 2026
7106a6d
Handle boolean telemetry entries without debug assert crash
Copilot May 13, 2026
cde453a
Apply suggestions from code review
Evangelink May 14, 2026
a450882
Fix telemetry compile regressions and test target compatibility
Copilot May 14, 2026
b9de99e
Wait for TrackEvent before disposing in boolean telemetry test
May 15, 2026
974495f
Address review feedback
May 15, 2026
3120811
Merge remote-tracking branch 'origin/main' into copilot/fix-test-fail…
Evangelink May 16, 2026
93554a4
Fix MSTEST0049 and IDE0028 analyzer errors in boolean telemetry test
Copilot May 16, 2026
f7d9aa5
Gate Microsoft.Testing.Platform using directive under #if DEBUG
Copilot May 16, 2026
4ee8c5c
Revert unrelated XLF changes
Copilot May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/Platform/Microsoft.Testing.Extensions.Telemetry/AppInsightsProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
using System.Threading.Channels;
#endif

using Microsoft.Testing.Platform;

Check failure on line 8 in src/Platform/Microsoft.Testing.Extensions.Telemetry/AppInsightsProvider.cs

View check run for this annotation

Azure Pipelines / microsoft.testfx (Build Linux Release)

src/Platform/Microsoft.Testing.Extensions.Telemetry/AppInsightsProvider.cs#L8 

src/Platform/Microsoft.Testing.Extensions.Telemetry/AppInsightsProvider.cs(8,1): error IDE0005: (NETCORE_ENGINEERING_TELEMETRY=Build) Using directive is unnecessary. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0005)

Check failure on line 8 in src/Platform/Microsoft.Testing.Extensions.Telemetry/AppInsightsProvider.cs

View check run for this annotation

Azure Pipelines / microsoft.testfx (Build Linux Release)

src/Platform/Microsoft.Testing.Extensions.Telemetry/AppInsightsProvider.cs#L8 

src/Platform/Microsoft.Testing.Extensions.Telemetry/AppInsightsProvider.cs(8,1): error IDE0005: (NETCORE_ENGINEERING_TELEMETRY=Build) Using directive is unnecessary. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0005)

Check failure on line 8 in src/Platform/Microsoft.Testing.Extensions.Telemetry/AppInsightsProvider.cs

View check run for this annotation

Azure Pipelines / microsoft.testfx (Build Linux Release)

src/Platform/Microsoft.Testing.Extensions.Telemetry/AppInsightsProvider.cs#L8 

src/Platform/Microsoft.Testing.Extensions.Telemetry/AppInsightsProvider.cs(8,1): error IDE0005: (NETCORE_ENGINEERING_TELEMETRY=Build) Using directive is unnecessary. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0005)

Check failure on line 8 in src/Platform/Microsoft.Testing.Extensions.Telemetry/AppInsightsProvider.cs

View check run for this annotation

Azure Pipelines / microsoft.testfx (Build MacOS Release)

src/Platform/Microsoft.Testing.Extensions.Telemetry/AppInsightsProvider.cs#L8 

src/Platform/Microsoft.Testing.Extensions.Telemetry/AppInsightsProvider.cs(8,1): error IDE0005: (NETCORE_ENGINEERING_TELEMETRY=Build) Using directive is unnecessary. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0005)

Check failure on line 8 in src/Platform/Microsoft.Testing.Extensions.Telemetry/AppInsightsProvider.cs

View check run for this annotation

Azure Pipelines / microsoft.testfx (Build MacOS Release)

src/Platform/Microsoft.Testing.Extensions.Telemetry/AppInsightsProvider.cs#L8 

src/Platform/Microsoft.Testing.Extensions.Telemetry/AppInsightsProvider.cs(8,1): error IDE0005: (NETCORE_ENGINEERING_TELEMETRY=Build) Using directive is unnecessary. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0005)

Check failure on line 8 in src/Platform/Microsoft.Testing.Extensions.Telemetry/AppInsightsProvider.cs

View check run for this annotation

Azure Pipelines / microsoft.testfx (Build MacOS Release)

src/Platform/Microsoft.Testing.Extensions.Telemetry/AppInsightsProvider.cs#L8 

src/Platform/Microsoft.Testing.Extensions.Telemetry/AppInsightsProvider.cs(8,1): error IDE0005: (NETCORE_ENGINEERING_TELEMETRY=Build) Using directive is unnecessary. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0005)
Comment thread
Evangelink marked this conversation as resolved.
using Microsoft.Testing.Platform.Configurations;
using Microsoft.Testing.Platform.Helpers;
using Microsoft.Testing.Platform.Logging;
Expand Down Expand Up @@ -37,7 +37,6 @@
private readonly bool _isCi;
private readonly IEnvironment _environment;
private readonly ITestApplicationCancellationTokenSource _testApplicationCancellationTokenSource;
private readonly ITask _task;
private readonly IClock _clock;
private readonly ITelemetryInformation _telemetryInformation;
private readonly ITelemetryClientFactory _telemetryClientFactory;
Expand Down Expand Up @@ -96,7 +95,6 @@
_environment = environment;
_currentSessionId = sessionId;
_testApplicationCancellationTokenSource = testApplicationCancellationTokenSource;
_task = task;
_clock = clock;
_telemetryInformation = telemetryInformation;
_telemetryClientFactory = telemetryClientFactory;
Expand Down Expand Up @@ -199,7 +197,6 @@
break;
#endif
case bool value:
RoslynDebug.Assert(false, $"Telemetry entry '{pair.Key}' contains a boolean value, boolean values should always be converted to string using: .{nameof(TelemetryExtensions.AsTelemetryBool)}()");
properties.Add(pair.Key, value.AsTelemetryBool());
break;
default:
Expand Down
125 changes: 125 additions & 0 deletions src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.cs.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,111 @@
<target state="translated">Očekávaná délka řetězce je {0}, ale byla {1}.</target>
<note></note>
</trans-unit>
<trans-unit id="AreEquivalentFailedSummary">
<source>Expected values to be structurally equivalent.</source>
<target state="new">Expected values to be structurally equivalent.</target>
Comment thread
Evangelink marked this conversation as resolved.
Outdated
<note />
</trans-unit>
<trans-unit id="AreEquivalentFailedSummaryStrict">
<source>Expected values to be structurally equivalent (strict mode).</source>
<target state="new">Expected values to be structurally equivalent (strict mode).</target>
<note />
</trans-unit>
<trans-unit id="AreEquivalentMismatchActualDictionaryThrew">
<source>reading the actual dictionary threw {0}: {1}.</source>
<target state="new">reading the actual dictionary threw {0}: {1}.</target>
<note />
</trans-unit>
<trans-unit id="AreEquivalentMismatchActualEnumerationThrew">
<source>enumerating the actual collection threw {0}: {1}.</source>
<target state="new">enumerating the actual collection threw {0}: {1}.</target>
<note />
</trans-unit>
<trans-unit id="AreEquivalentMismatchActualMemberThrew">
<source>reading the actual member threw {0}: {1}.</source>
<target state="new">reading the actual member threw {0}: {1}.</target>
<note />
</trans-unit>
<trans-unit id="AreEquivalentMismatchAt">
<source>Mismatch at '{0}': {1}</source>
<target state="new">Mismatch at '{0}': {1}</target>
<note>{0} is a member path (e.g., 'Order.Items[2].Price'), {1} is a localized reason describing the kind of mismatch.</note>
</trans-unit>
<trans-unit id="AreEquivalentMismatchExpectedDictionaryThrew">
<source>reading the expected dictionary threw {0}: {1}.</source>
<target state="new">reading the expected dictionary threw {0}: {1}.</target>
<note />
</trans-unit>
<trans-unit id="AreEquivalentMismatchExpectedEnumerationThrew">
<source>enumerating the expected collection threw {0}: {1}.</source>
<target state="new">enumerating the expected collection threw {0}: {1}.</target>
<note />
</trans-unit>
<trans-unit id="AreEquivalentMismatchExpectedMemberThrew">
<source>reading the expected member threw {0}: {1}.</source>
<target state="new">reading the expected member threw {0}: {1}.</target>
<note />
</trans-unit>
<trans-unit id="AreEquivalentMismatchExtraMembers">
<source>actual has unexpected members not present on expected: {0}.</source>
<target state="new">actual has unexpected members not present on expected: {0}.</target>
<note />
</trans-unit>
<trans-unit id="AreEquivalentMismatchIEquatableThrew">
<source>IEquatable.Equals threw {0}: {1}.</source>
<target state="new">IEquatable.Equals threw {0}: {1}.</target>
<note />
</trans-unit>
<trans-unit id="AreEquivalentMismatchLength">
<source>collections differ in length (expected {0} elements, actual {1}).</source>
<target state="new">collections differ in length (expected {0} elements, actual {1}).</target>
<note />
</trans-unit>
<trans-unit id="AreEquivalentMismatchMaxDepth">
<source>comparison exceeded the maximum supported depth of {0}.</source>
<target state="new">comparison exceeded the maximum supported depth of {0}.</target>
<note />
</trans-unit>
<trans-unit id="AreEquivalentMismatchMissingKey">
<source>key {0} present on expected is missing from actual.</source>
<target state="new">key {0} present on expected is missing from actual.</target>
<note />
</trans-unit>
<trans-unit id="AreEquivalentMismatchMissingMember">
<source>member '{0}' present on expected is missing from actual.</source>
<target state="new">member '{0}' present on expected is missing from actual.</target>
<note />
</trans-unit>
<trans-unit id="AreEquivalentMismatchNull">
<source>one side is null, the other is not.</source>
<target state="new">one side is null, the other is not.</target>
<note />
</trans-unit>
<trans-unit id="AreEquivalentMismatchTopology">
<source>graph topology differs (the same reference on one side appears paired with different references on the other side).</source>
<target state="new">graph topology differs (the same reference on one side appears paired with different references on the other side).</target>
<note />
</trans-unit>
<trans-unit id="AreEquivalentMismatchType">
<source>incompatible types (expected '{0}', actual '{1}').</source>
<target state="new">incompatible types (expected '{0}', actual '{1}').</target>
<note />
</trans-unit>
<trans-unit id="AreEquivalentMismatchUnexpectedKey">
<source>key {0} present on actual is not on expected.</source>
<target state="new">key {0} present on actual is not on expected.</target>
<note />
</trans-unit>
<trans-unit id="AreEquivalentMismatchValue">
<source>values are not equal.</source>
<target state="new">values are not equal.</target>
<note />
</trans-unit>
<trans-unit id="AreEquivalentRootPath">
<source>&lt;root&gt;</source>
<target state="new">&lt;root&gt;</target>
<note>Placeholder used in equivalence-mismatch messages when the difference is at the top of the object graph.</note>
</trans-unit>
<trans-unit id="AreNotEqualFailMsg">
<source>Expected any value except:&lt;{1}&gt;. Actual:&lt;{2}&gt;. {0}</source>
<target state="translated">Nebyla očekávána žádná hodnota kromě:&lt;{1}&gt;. Aktuálně:&lt;{2}&gt;. {0}</target>
Expand All @@ -78,6 +183,26 @@
<target state="translated">Očekáván rozdíl, který je větší jak &lt;{3}&gt; mezi očekávanou hodnotou &lt;{1}&gt; a aktuální hodnotou &lt;{2}&gt;. {0}</target>
<note></note>
</trans-unit>
<trans-unit id="AreNotEquivalentComparisonFailedSummary">
<source>Could not complete structural comparison.</source>
<target state="new">Could not complete structural comparison.</target>
<note />
</trans-unit>
<trans-unit id="AreNotEquivalentComparisonFailedSummaryStrict">
<source>Could not complete structural comparison (strict mode).</source>
<target state="new">Could not complete structural comparison (strict mode).</target>
<note />
</trans-unit>
<trans-unit id="AreNotEquivalentFailedSummary">
<source>Expected values to be structurally different.</source>
<target state="new">Expected values to be structurally different.</target>
<note />
</trans-unit>
<trans-unit id="AreNotEquivalentFailedSummaryStrict">
<source>Expected values to be structurally different (strict mode).</source>
<target state="new">Expected values to be structurally different (strict mode).</target>
<note />
</trans-unit>
<trans-unit id="AreNotSameBothNull">
<source>Both values are &lt;null&gt;. {0}</source>
<target state="translated">Obě hodnoty jsou &lt;null&gt;. {0}</target>
Expand Down
125 changes: 125 additions & 0 deletions src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.de.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,111 @@
<target state="translated">Die erwartete Länge der Zeichenfolge ist {0}, war aber {1}.</target>
<note></note>
</trans-unit>
<trans-unit id="AreEquivalentFailedSummary">
<source>Expected values to be structurally equivalent.</source>
<target state="new">Expected values to be structurally equivalent.</target>
Comment thread
Evangelink marked this conversation as resolved.
Outdated
<note />
</trans-unit>
<trans-unit id="AreEquivalentFailedSummaryStrict">
<source>Expected values to be structurally equivalent (strict mode).</source>
<target state="new">Expected values to be structurally equivalent (strict mode).</target>
<note />
</trans-unit>
<trans-unit id="AreEquivalentMismatchActualDictionaryThrew">
<source>reading the actual dictionary threw {0}: {1}.</source>
<target state="new">reading the actual dictionary threw {0}: {1}.</target>
<note />
</trans-unit>
<trans-unit id="AreEquivalentMismatchActualEnumerationThrew">
<source>enumerating the actual collection threw {0}: {1}.</source>
<target state="new">enumerating the actual collection threw {0}: {1}.</target>
<note />
</trans-unit>
<trans-unit id="AreEquivalentMismatchActualMemberThrew">
<source>reading the actual member threw {0}: {1}.</source>
<target state="new">reading the actual member threw {0}: {1}.</target>
<note />
</trans-unit>
<trans-unit id="AreEquivalentMismatchAt">
<source>Mismatch at '{0}': {1}</source>
<target state="new">Mismatch at '{0}': {1}</target>
<note>{0} is a member path (e.g., 'Order.Items[2].Price'), {1} is a localized reason describing the kind of mismatch.</note>
</trans-unit>
<trans-unit id="AreEquivalentMismatchExpectedDictionaryThrew">
<source>reading the expected dictionary threw {0}: {1}.</source>
<target state="new">reading the expected dictionary threw {0}: {1}.</target>
<note />
</trans-unit>
<trans-unit id="AreEquivalentMismatchExpectedEnumerationThrew">
<source>enumerating the expected collection threw {0}: {1}.</source>
<target state="new">enumerating the expected collection threw {0}: {1}.</target>
<note />
</trans-unit>
<trans-unit id="AreEquivalentMismatchExpectedMemberThrew">
<source>reading the expected member threw {0}: {1}.</source>
<target state="new">reading the expected member threw {0}: {1}.</target>
<note />
</trans-unit>
<trans-unit id="AreEquivalentMismatchExtraMembers">
<source>actual has unexpected members not present on expected: {0}.</source>
<target state="new">actual has unexpected members not present on expected: {0}.</target>
<note />
</trans-unit>
<trans-unit id="AreEquivalentMismatchIEquatableThrew">
<source>IEquatable.Equals threw {0}: {1}.</source>
<target state="new">IEquatable.Equals threw {0}: {1}.</target>
<note />
</trans-unit>
<trans-unit id="AreEquivalentMismatchLength">
<source>collections differ in length (expected {0} elements, actual {1}).</source>
<target state="new">collections differ in length (expected {0} elements, actual {1}).</target>
<note />
</trans-unit>
<trans-unit id="AreEquivalentMismatchMaxDepth">
<source>comparison exceeded the maximum supported depth of {0}.</source>
<target state="new">comparison exceeded the maximum supported depth of {0}.</target>
<note />
</trans-unit>
<trans-unit id="AreEquivalentMismatchMissingKey">
<source>key {0} present on expected is missing from actual.</source>
<target state="new">key {0} present on expected is missing from actual.</target>
<note />
</trans-unit>
<trans-unit id="AreEquivalentMismatchMissingMember">
<source>member '{0}' present on expected is missing from actual.</source>
<target state="new">member '{0}' present on expected is missing from actual.</target>
<note />
</trans-unit>
<trans-unit id="AreEquivalentMismatchNull">
<source>one side is null, the other is not.</source>
<target state="new">one side is null, the other is not.</target>
<note />
</trans-unit>
<trans-unit id="AreEquivalentMismatchTopology">
<source>graph topology differs (the same reference on one side appears paired with different references on the other side).</source>
<target state="new">graph topology differs (the same reference on one side appears paired with different references on the other side).</target>
<note />
</trans-unit>
<trans-unit id="AreEquivalentMismatchType">
<source>incompatible types (expected '{0}', actual '{1}').</source>
<target state="new">incompatible types (expected '{0}', actual '{1}').</target>
<note />
</trans-unit>
<trans-unit id="AreEquivalentMismatchUnexpectedKey">
<source>key {0} present on actual is not on expected.</source>
<target state="new">key {0} present on actual is not on expected.</target>
<note />
</trans-unit>
<trans-unit id="AreEquivalentMismatchValue">
<source>values are not equal.</source>
<target state="new">values are not equal.</target>
<note />
</trans-unit>
<trans-unit id="AreEquivalentRootPath">
<source>&lt;root&gt;</source>
<target state="new">&lt;root&gt;</target>
<note>Placeholder used in equivalence-mismatch messages when the difference is at the top of the object graph.</note>
</trans-unit>
<trans-unit id="AreNotEqualFailMsg">
<source>Expected any value except:&lt;{1}&gt;. Actual:&lt;{2}&gt;. {0}</source>
<target state="translated">Es wurde ein beliebiger Wert erwartet außer:&lt;{1}&gt;. Tatsächlich:&lt;{2}&gt;. {0}</target>
Expand All @@ -78,6 +183,26 @@
<target state="translated">Es wurde eine Differenz größer als &lt;{3}&gt; zwischen dem erwarteten Wert &lt;{1}&gt; und dem tatsächlichen Wert &lt;{2}&gt; erwartet. {0}</target>
<note></note>
</trans-unit>
<trans-unit id="AreNotEquivalentComparisonFailedSummary">
<source>Could not complete structural comparison.</source>
<target state="new">Could not complete structural comparison.</target>
<note />
</trans-unit>
<trans-unit id="AreNotEquivalentComparisonFailedSummaryStrict">
<source>Could not complete structural comparison (strict mode).</source>
<target state="new">Could not complete structural comparison (strict mode).</target>
<note />
</trans-unit>
<trans-unit id="AreNotEquivalentFailedSummary">
<source>Expected values to be structurally different.</source>
<target state="new">Expected values to be structurally different.</target>
<note />
</trans-unit>
<trans-unit id="AreNotEquivalentFailedSummaryStrict">
<source>Expected values to be structurally different (strict mode).</source>
<target state="new">Expected values to be structurally different (strict mode).</target>
<note />
</trans-unit>
<trans-unit id="AreNotSameBothNull">
<source>Both values are &lt;null&gt;. {0}</source>
<target state="translated">Beide Werte sind &lt;null&gt;. {0}</target>
Expand Down
Loading
Loading