Skip to content

Move RFC 012 (Structured Assertion Messages) into Implementation status#8257

Merged
Evangelink merged 1 commit into
mainfrom
dev/amauryleve/rfc012-implementation
May 15, 2026
Merged

Move RFC 012 (Structured Assertion Messages) into Implementation status#8257
Evangelink merged 1 commit into
mainfrom
dev/amauryleve/rfc012-implementation

Conversation

@Evangelink
Copy link
Copy Markdown
Member

Following the merges of #8170 (infrastructure), #8187 (IsTrue/IsFalse/IsNull/IsNotNull), #8210 (exception assertions), and #8214 (reference and type assertions), RFC 012 has effectively moved past the discussion phase. This PR updates the RFC status checkboxes accordingly:

  • Approved in principle
  • Under discussion
  • Implementation
  • Shipped

The remaining assertion families (AreEqual/AreNotEqual, IsSubsetOf/IsNotSubsetOf, AllItemsAreNotNull/AreUnique/AreInstancesOfType, StringAssert, CollectionAssert, Assert.Contains/Count, etc.) will continue to be migrated in follow-up PRs.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

The structured assertion message format described in RFC 012 has been approved and the infrastructure (#8170) plus several assertion families (IsTrue/IsFalse/IsNull/IsNotNull, exception assertions, reference and type assertions) have already been migrated. Mark the RFC as Approved in principle and Implementation.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 15, 2026 13:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the status checkboxes of RFC 012 (Structured Assertion Messages) to reflect that it has been approved in principle and is now in the implementation phase, following the merge of several PRs (#8170, #8187, #8210, #8214) that have built out the infrastructure and migrated multiple assertion families.

Changes:

  • Mark "Approved in principle" as checked.
  • Uncheck "Under discussion".
  • Mark "Implementation" as checked.
Show a summary per file
File Description
docs/RFCs/012-Structured-Assertion-Messages.md Updates RFC status checkboxes to reflect movement from discussion to implementation phase.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

Copy link
Copy Markdown
Member Author

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expert Review: PR #8257 — Move RFC 012 into Implementation status

Summary

This PR is a documentation-only change — it updates three checkbox states in docs/RFCs/012-Structured-Assertion-Messages.md to reflect that RFC 012 has progressed from Under discussion to Approved in principle and Implementation.


Dimension Verdict Table

# Dimension Verdict
1 Algorithmic Correctness ✅ N/A
2 Threading & Concurrency ✅ N/A
3 Security & IPC Contract Safety ✅ N/A
4 Public API Surface & PublicAPI.Unshipped.txt ✅ N/A
5 Backward Compatibility ✅ N/A
6 Performance ✅ N/A
7 Cross-TFM Correctness ✅ N/A
8 Localization ✅ N/A
9 Test Coverage ✅ N/A
10 Error Handling & Diagnostics ✅ N/A
11 Code Style & Conventions ✅ Clean
12 Naming Conventions ✅ N/A
13 Documentation & XML Docs ✅ Clean — status accurately reflects merged PRs
14 init Accessor Policy ✅ N/A
15 Resource / .resx Hygiene ✅ N/A
16 IPC Contract Stability ✅ N/A
17 Scope Discipline ✅ Single, atomic concern
18 Dependency Management ✅ N/A
19 Build & CI Impact ✅ N/A
20 Agentic Workflow Compilation ✅ N/A
21 General Correctness ✅ Clean

Findings

No issues found. The checkbox states are consistent with the referenced merged PRs (#8170, #8187, #8210, #8214). The Shipped checkbox is correctly left unchecked.

All clear. ✅

Generated by Expert Code Review (on open) for issue #8257 · ● 2.8M

@Evangelink Evangelink enabled auto-merge (squash) May 15, 2026 13:29
@Evangelink Evangelink merged commit 487756d into main May 15, 2026
28 checks passed
@Evangelink Evangelink deleted the dev/amauryleve/rfc012-implementation branch May 15, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants