Use JS-compatible Unicode casing for intrinsic string mappings#3495
Open
Andarist wants to merge 3 commits intomicrosoft:mainfrom
Open
Use JS-compatible Unicode casing for intrinsic string mappings#3495Andarist wants to merge 3 commits intomicrosoft:mainfrom
Andarist wants to merge 3 commits intomicrosoft:mainfrom
Conversation
jakebailey
reviewed
Apr 22, 2026
Member
jakebailey
left a comment
jakebailey
left a comment
There was a problem hiding this comment.
I am very uneasy about this. Why can't we use Go's unicode ranges to do this? How can we make sure this is up to date long term?
| package stringutil | ||
|
|
||
| //go:generate node --experimental-strip-types --no-warnings ./_scripts/generate-special-casing.mts | ||
| //go:generate gofmt -w js_case_generated.go |
Comment on lines
+8
to
+9
| func ToLowerJS(str string) string { | ||
| runes := []rune(str) |
Member
There was a problem hiding this comment.
This perf of this is going to be abysmal; surely we can bail out for ascii?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3489