Skip to content

Stabilize playground save-shortcut e2e by removing navigation-based URL wait #10868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
+4 −8
Draft

Stabilize playground save-shortcut e2e by removing navigation-based URL wait #10868

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de89b69
Fix flaky URL wait in playground save e2e test
Copilot Jun 2, 2026
b3b5993
Format playground save e2e URL assertion
Copilot Jun 2, 2026
f50a06b
Fix spellcheck warning in playground save e2e test
Copilot Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions packages/playground-website/e2e/ui.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,9 @@ test.describe("playground UI tests", () => {
const typespecEditor = page.locator(".monaco-editor").first();
await typespecEditor.click();
await typespecEditor.pressSequentially("op sharedCode(): string;");
await Promise.all([
// It is important to call waitForNavigation before click to set up waiting.
page.waitForURL(
// cspell:disable-next-line
new RegExp(`${host}/\\?.*c=b3Agc2hhcmVkQ29kZSgpOiBzdHJpbmc7.*`),
),
page.keyboard.press(`${ctrlOrCmd}+KeyS`),
]);
await page.keyboard.press(`${ctrlOrCmd}+KeyS`);
// cspell:disable-next-line
const sharedCodeQueryPattern = new RegExp(`${host}/\\?.*c=b3Agc2hhcmVkQ29kZSgpOiBzdHJpbmc7.*`);
await expect.poll(() => page.url()).toMatch(sharedCodeQueryPattern);
});
});