Fix invalid json files detected for claude hook paths

[pwang347]

Refactor concept of parent to be a searchRoot. In the case of hook files, we just need to watch specific files (settings.json) not folders.

Fixes #304314

[github-actions]

Screenshot Changes

Base: 1f9cd94d Current: 711db634

Changed (1)

chat/aiCustomizations/aiCustomizationManagementEditor/McpBrowseMode/Light

Before	After

[Copilot]

Pull request overview

This PR fixes hook file discovery so that configured specific .json hook paths (notably Claude’s .claude/settings*.json) are treated as individual files rather than causing sibling .json files in the same directory to be picked up.

Changes:

• Adjust hook location resolution to use a searchRoot concept (file or directory) instead of always using a “parent folder”, preventing accidental inclusion of sibling .json files.
• Update consumers of the resolved-folder metadata to use searchRoot.
• Add tests validating that hook discovery returns only targeted .json files (and not sibling .json files).

Show a summary per file

File	Description
src/vs/workbench/contrib/chat/test/common/promptSyntax/utils/promptFilesLocator.test.ts	Adds coverage for hook discovery to ensure only configured .json files are returned.
src/vs/workbench/contrib/chat/common/promptSyntax/utils/promptFilesLocator.ts	Changes resolution and scanning logic to use searchRoot for hook paths (file vs directory).
src/vs/workbench/contrib/chat/common/promptSyntax/config/promptFileLocations.ts	Renames resolved-folder metadata from parent to searchRoot.
src/vs/workbench/contrib/chat/browser/promptSyntax/pickers/askForPromptSourceFolder.ts	Updates picker logic to reference searchRoot instead of the removed parent property.

Copilot's findings

Comments suppressed due to low confidence (1)

src/vs/workbench/contrib/chat/common/promptSyntax/utils/promptFilesLocator.ts:872

• The JSDoc for resolveSearchLocation still references the old getParentFolder name and { parent, filePattern } shape in the example. Please update the example and wording to use resolveSearchLocation(...) and { searchRoot, filePattern } so the docs match the actual API.

 * assert.strictDeepEqual(
 *     getParentFolder(PromptsType.prompt, URI.file('/home/user/{folder1,folder2}/file.md')),
 *     { parent: URI.file('/home/user'), filePattern: '{folder1,folder2}/file.md' },
 *     'Must find correct non-glob parent dirname.',
 * );

• Files reviewed: 4/4 changed files
• Comments generated: 1