Skip to content

Don't publish dev blocks#1602

Open
AStaroverov wants to merge 1 commit into
mainfrom
fix/stop-publish-develop-blocks
Open

Don't publish dev blocks#1602
AStaroverov wants to merge 1 commit into
mainfrom
fix/stop-publish-develop-blocks

Conversation

@AStaroverov

@AStaroverov AStaroverov commented Apr 29, 2026

Copy link
Copy Markdown
Collaborator

Greptile Summary

This PR marks 12 package.json files across three dev/test blocks (monetization-test, pool-explorer, ui-examples) as "private": true to prevent accidental npm publishing. The change is straightforward and correct, but an unintended git submodule was committed alongside it.

  • P1: .claude/worktrees/agent-ab4e51f5114eeb3aa is a temporary Claude Code agent worktree accidentally registered as a git submodule. It points to a non-existent external commit and will break git submodule update for anyone cloning the repo. This entry should be removed and .claude/worktrees/ added to .gitignore.

Confidence Score: 3/5

Not safe to merge as-is — an accidental git submodule pointing to an unresolvable commit needs to be removed first.

The package.json changes are correct and low-risk, but the committed Claude Code worktree submodule is a P1 issue that will break git submodule update for all cloners and pollutes the repo's submodule registry.

.claude/worktrees/agent-ab4e51f5114eeb3aa — accidental submodule that must be removed

Important Files Changed

Filename Overview
.claude/worktrees/agent-ab4e51f5114eeb3aa Accidental git submodule pointing to a temporary Claude Code agent worktree — should not be committed
.changeset/twelve-turkeys-carry.md Empty changeset file (no package version bumps) — appropriate for a non-library internal change
etc/blocks/monetization-test/block/package.json Adds "private": true to prevent accidental npm publishing of this dev block
etc/blocks/pool-explorer/block/package.json Adds "private": true to prevent accidental npm publishing of this dev block
etc/blocks/ui-examples/block/package.json Adds "private": true to prevent accidental npm publishing of this dev block
Prompt To Fix All With AI
This is a comment left during a code review.
Path: .claude/worktrees/agent-ab4e51f5114eeb3aa
Line: 1

Comment:
**Accidental git submodule committed**

This file registers a temporary Claude Code agent worktree as a git submodule, pointing to commit `8132ee5d4bbfe44153a766c039c08ecefdeed65e`. The `.claude/worktrees/` directory is created by Claude Code during agent sessions and should never be committed to the repository. This will cause issues for anyone cloning the repo (the submodule will be missing/unresolvable) and should be removed. Consider adding `.claude/worktrees/` to `.gitignore`.

How can I resolve this? If you propose a fix, please make it concise.

Reviews (1): Last reviewed commit: "unpublish dev blocks" | Re-trigger Greptile

Greptile also left 1 inline comment on this PR.

@changeset-bot

changeset-bot Bot commented Apr 29, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 5c80323

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -0,0 +1 @@
Subproject commit 8132ee5d4bbfe44153a766c039c08ecefdeed65e

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Accidental git submodule committed

This file registers a temporary Claude Code agent worktree as a git submodule, pointing to commit 8132ee5d4bbfe44153a766c039c08ecefdeed65e. The .claude/worktrees/ directory is created by Claude Code during agent sessions and should never be committed to the repository. This will cause issues for anyone cloning the repo (the submodule will be missing/unresolvable) and should be removed. Consider adding .claude/worktrees/ to .gitignore.

Prompt To Fix With AI
This is a comment left during a code review.
Path: .claude/worktrees/agent-ab4e51f5114eeb3aa
Line: 1

Comment:
**Accidental git submodule committed**

This file registers a temporary Claude Code agent worktree as a git submodule, pointing to commit `8132ee5d4bbfe44153a766c039c08ecefdeed65e`. The `.claude/worktrees/` directory is created by Claude Code during agent sessions and should never be committed to the repository. This will cause issues for anyone cloning the repo (the submodule will be missing/unresolvable) and should be removed. Consider adding `.claude/worktrees/` to `.gitignore`.

How can I resolve this? If you propose a fix, please make it concise.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request marks several internal block packages as private by adding the "private": true field to their package.json files across the monetization-test, pool-explorer, and ui-examples directories. Feedback was provided to also remove the prepublishOnly scripts in the block-specific package.json files, as these scripts still contain commands to publish to a custom S3 registry, which contradicts the goal of preventing the publication of development blocks.

{
"name": "@milaboratories/milaboratories.monetization-test",
"version": "1.4.0",
"private": true,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While marking the package as private prevents accidental publishing to the default registry, the prepublishOnly script (on line 7) still contains a command to publish the block to a custom S3 registry. To fully align with the goal of "not publishing dev blocks", consider removing this script as well.

{
"name": "@milaboratories/milaboratories.pool-explorer",
"version": "1.2.0",
"private": true,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While marking the package as private prevents accidental publishing to the default registry, the prepublishOnly script (on line 7) still contains a command to publish the block to a custom S3 registry. To fully align with the goal of "not publishing dev blocks", consider removing this script as well.

{
"name": "@milaboratories/milaboratories.ui-examples",
"version": "1.3.0",
"private": true,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While marking the package as private prevents accidental publishing to the default registry, the prepublishOnly script (on line 7) still contains a command to publish the block to a custom S3 registry. To fully align with the goal of "not publishing dev blocks", consider removing this script as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants