feat(ui): replace rule inputs with textareas for multiline support#4268
Open
mtsz-pl wants to merge 1 commit into
Open
feat(ui): replace rule inputs with textareas for multiline support#4268mtsz-pl wants to merge 1 commit into
mtsz-pl wants to merge 1 commit into
Conversation
fguillot
requested changes
Apr 27, 2026
fguillot
left a comment
fguillot
left a comment
Member
There was a problem hiding this comment.
This change introduces a few regressions:
urlrewrite_rules: the backend still only accepts a single exactrewrite("..."|"...")expression. Any newline, including a trailing one, makes URL rewriting stop working.scraper_rules: the backend still passes the whole value as one CSS selector. Newlines are treated as selector whitespace/descendant combinators, not as separate rules, so multiline input changes selector meaning instead of adding multiple rules.blocklist_rules/keeplist_rules: these are still compiled as a single regex each. Newline-separated entries do not become multiple filters.
Only the rewrite_rules is safe because it uses text/scanner.
Contributor
Author
|
I have added tests for multiline rules and updated the code. I think all cases are covered. |
mtsz-pl
force-pushed
the
textarea
branch
3 times, most recently
from
735952c to
beeec19
Compare
It is valid to use multiple rules for feed processing, and textarea with multiline support is more suitable for display/editing, than single-lined input. All rules properly handle whitespaces and newlines, so there is no regression. # Conflicts: # internal/reader/scraper/scraper.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is valid to use multiple rules for feed processing, and textarea with multiline support is more suitable for display/editing, than single-lined input. All rules properly handle whitespaces and newlines, so there is no regression.
Have you followed these guidelines?