perf: use strings.Builder in storage for constructing queries#4300
Draft
gudvinr wants to merge 9 commits into
Draft
perf: use strings.Builder in storage for constructing queries#4300gudvinr wants to merge 9 commits into
gudvinr wants to merge 9 commits into
Conversation
Contributor
Author
|
I haven't really tested these yet as there are no unit tests. At first glance, changes are pretty straightforward. No benchmark code is added because queries are built right before doing actual request to DB. Not sure how to do any meaningful benchmark for that. |
gudvinr
force-pushed
the
feature/qb_where_builder
branch
from
0975e61 to
93c4666
Compare
gudvinr
force-pushed
the
feature/qb_where_builder
branch
4 times, most recently
from
2a895c4 to
da2b218
Compare
gudvinr
force-pushed
the
feature/qb_where_builder
branch
from
da2b218 to
c34fea9
Compare
gudvinr
force-pushed
the
feature/qb_where_builder
branch
from
c34fea9 to
c8eb3e7
Compare
Handle default arguments early. That makes function flat so it's easy to skim over.
gudvinr
force-pushed
the
feature/qb_where_builder
branch
from
c8eb3e7 to
098d1d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have you followed these guidelines?
Assembling
WHEREexpressions is pretty straightforward as those are building up and there's noORanywhere inside builder.Similarly,
ORDER BYbuilds up with a simple append operation.