make request/response builders actually build#4366
Open
gudvinr wants to merge 3 commits into
Open
Conversation
5048042 to
901afaa
Compare
fguillot
requested changes
Jun 6, 2026
fguillot
left a comment
Member
There was a problem hiding this comment.
There is a regression in FindSubscriptions. Previously redirects were only disabled for well-known feed probes in findSubscriptionsFromWellKnownURLs. Now the WithoutRedirects() is applied to the shared RequestBuilder before FindSubscriptions(). This breaks common subscription flows with expected redirects.
Contributor
Author
As Went back to previous behaviour anyway. This indeed doesn't look like a good solution. |
Correct use of builder assumes that each step makes isolated instance. Thus, not using result of build step makes builder just ignore that action.
901afaa to
78be371
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a follow-up for #4353. Sorry for the noise.
Didn't occur to me that request/response builders are actually not being used as builders.
Couple notes here:
CreateFeedFromSubscriptionDiscoverymade useless builder. It is supposedly intended to be used withNewIconCheckerbutNewIconCheckermakes its own builder.I removed builder in
CreateFeedFromSubscriptionDiscoverybecause it wasn't used. If that's the one actually should've been used in first place, please let me know.In theory builders should be immutable. I.e. if you do
newBuilder := oldBuilder.Sumsin(...), state ofoldBuilderis unchanged.With that assumption in mind (this is just my guess)
subscriptionFinder.findSubscriptionsFromWellKnownURLscalledWithoutRedirectsin a loop for each URL. That in theory should create ephemeral builder with redirects disabled but in fact it just disables redirects over and over for no reason.To be able to use that technique one probably should actually make real builder that doesn't change global builder state. However, currently no builder in miniflux does that and it'd be quite tedious task for basically no gain.
I've decided to just move
WithoutRedirectsup so it's just explicitly does what it's already doing. If something else should be done insted, I'm all ears.Have you followed these guidelines?