make parsing Accept-Encoding almost spec-compliant#4370
Open
gudvinr wants to merge 2 commits into
Open
Conversation
gudvinr
force-pushed
the
feature/response_encoding_parser
branch
from
341b3b6 to
57f9c92
Compare
gudvinr
force-pushed
the
feature/response_encoding_parser
branch
from
57f9c92 to
ab64b5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've tried to add as much test cases as possible including real
Accept-Encodingfrom my browsers.Functionally this code should behave exactly the same as before but will a bit more predictable when clients are not well behaving. I really doubt that any of the good clients will send something like
broomstick,gzip,flate.switch/caselooks better though.Have you followed these guidelines?