Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 34 additions & 3 deletions internal/http/response/builder.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,38 @@ import (
"mime"
"net/http"
"strings"
"sync"
"time"

"github.com/andybalholm/brotli"
"github.com/andybalholm/brotli/matchfinder"
)

const compressionThreshold = 1024

// Compression writers are pooled so each request reuses their internal
// state (brotli sliding window + hash tables, flate dictionary, etc.)
// instead of allocating it from scratch. Reset(dst) rebinds the
// destination without re-allocating the buffers.
var (
brotliWriterPool = sync.Pool{
New: func() any {
return brotli.NewWriterV2(io.Discard, brotli.DefaultCompression)
},
}
gzipWriterPool = sync.Pool{
New: func() any {
return gzip.NewWriter(io.Discard)
},
}
flateWriterPool = sync.Pool{
New: func() any {
w, _ := flate.NewWriter(io.Discard, flate.DefaultCompression)
return w
},
}
)

// Builder generates HTTP responses.
type Builder struct {
w http.ResponseWriter
Expand Down Expand Up @@ -139,25 +164,31 @@ func (b *Builder) compress(data []byte) {
b.headers.Set("Content-Encoding", "br")
b.writeHeaders()

brotliWriter := brotli.NewWriterV2(b.w, brotli.DefaultCompression)
brotliWriter := brotliWriterPool.Get().(*matchfinder.Writer)
brotliWriter.Reset(b.w)
brotliWriter.Write(data)
brotliWriter.Close()
brotliWriterPool.Put(brotliWriter)
return
case strings.Contains(acceptEncoding, "gzip"):
b.headers.Set("Content-Encoding", "gzip")
b.writeHeaders()

gzipWriter := gzip.NewWriter(b.w)
gzipWriter := gzipWriterPool.Get().(*gzip.Writer)
gzipWriter.Reset(b.w)
gzipWriter.Write(data)
gzipWriter.Close()
gzipWriterPool.Put(gzipWriter)
return
case strings.Contains(acceptEncoding, "deflate"):
b.headers.Set("Content-Encoding", "deflate")
b.writeHeaders()

flateWriter, _ := flate.NewWriter(b.w, -1)
flateWriter := flateWriterPool.Get().(*flate.Writer)
flateWriter.Reset(b.w)
flateWriter.Write(data)
flateWriter.Close()
flateWriterPool.Put(flateWriter)
return
}
}
Expand Down
Loading