feat(atom): use id for entry link if it is an http URL#4387
Open
kellegous wants to merge 1 commit into
Open
Conversation
kellegous
force-pushed
the
id-url-fallback
branch
from
e06a992 to
c3f59d4
Compare
dsh2dsh
added a commit
to dsh2dsh/miniflux
that referenced
this pull request
Jun 9, 2026
kellegous
force-pushed
the
id-url-fallback
branch
from
c3f59d4 to
ac72cea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have you followed these guidelines?
It is valid for an atom 1.0 feed to include no links in the entries. For instance,
https://sinclairtarget.com/feed.xmlpasses validation. miniflux currently currently parses empty urls for every entry in that feed. However, the<id>element for atom is specified as an IRI ... which might be a URL. This change attempts to use theidvalue as the entry URL. If that doesn't work, it uses the site URL, just to ensure the entry has a url.There is nothing in the atom spec that recommends using the
idif there is no link. It is just intended as a globally unique identifier. Practically, though, the permalink is valid and widely used as theid. Just to double check myself, I looked at what a couple of other readers do.idas the URL unconditionally, even if it's not an http-based URLhttps://sinclairtarget.com/feed.xml is a good example to test against.