Fix multiselect drag to backpack#3889
Merged
ewpatton merged 7 commits intoMay 5, 2026
Merged
Conversation
local_declaration_expression local_declaration_statement procedures_defanonnoreturn procedures_defanonreturn procedures_defnoreturn procedures_defreturn mit-cml/blockly-plugins@989d8a0
Contributor
Author
|
@ewpatton I think these commits should be merged individually. They are independent and each incrementally improve the situation. Will make reading the history better if we do more work to get headless working in the future for other more interesting purposes then a workaround. Also easier to revert if a particular one causes an issue. They do not build on or depend on each other. |
josmas
reviewed
Apr 17, 2026
josmas
reviewed
Apr 17, 2026
josmas
reviewed
Apr 17, 2026
josmas
approved these changes
Apr 22, 2026
Member
josmas
left a comment
josmas
left a comment
There was a problem hiding this comment.
LGTM, thanks. Approving but please make the suggested change.
Contributor
Author
Contributor
Author
|
works on |
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR accomplish?
This PR addresses a regression caused by the update to Blockly 11.
This PR adds a similar headless workspace json/xml conversion workaround to dragging multiple blocks to the backpack that was used for paste all blocks from backpack. Additionally it fixes a few things so headless worksapces work with more block types. I don't know of any more right now that don't work but they could be out there. Important to note that all other backpack uses cases, including dragging a single block to it, do not make use of this workaround.
.Context for the changes
If this PR changes anything related to the companion make sure you have used the
ucrbranch. For all other changes usemasteror provide context for having used a different branch.See a summary of git branches in the docs: App Inventor Developer Overview
If your code changes how something works on the device (i.e., it affects the companion):
I have made no changes that affect the companion
I branched from
ucrMy pull request has
ucras the baseFurther, if you've changed the blocks language or another user-facing designer/blocks API (added a SimpleProperty, etc.):
For all other changes:
I have made no changes that affect the master branch
I branched from
masterMy pull request has
masteras the baseGeneral items:
ant testspasses on my machine