feat: Stop webp images from being processed to allow animated webp images#6060
feat: Stop webp images from being processed to allow animated webp images#6060P4ncake4451 wants to merge 1 commit into
Conversation
This allows webp images to stay animated without being processed into the same format, also avoids processing the same format into the same format Signed-off-by: P4ncake <76443059+P4ncake4451@users.noreply.github.com>
Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
|
this seems like it would also remove the resizing functionality, that should be kept |
Why should gifs skip resizing though, that's what I don't understand |
|
they really shouldn't be, sounds like a bug |
It kidna looks like someone made a bandaid fix for gifs not animating after being processed, so they skipped processing them altogether, I've checked the script and if you disable that line which prevents gifs from being processed, it disables their animation after processing, despite webp supporting animation, same happened to animtated webps before |
|
yeah, I think that is probably the case. ideally the resizing would be able to support animated ones too, but I understand if that's a little out of scope for what you wanted to do with this PR. at least webp images will be smaller in size than a lot of other images, but I could still see this having a bandwidth impact if suddenly no webp images are downsized by default (though, I do not think that many people are uploading webp by default) |
|
Ideally gifs should also be converted to animated webps to save bandwidth, because the gif compression is horrible, but that'd need to come with animated webp support at the same time |
|
yeah agreed |
Webp images in the project galleries and icons are no longer being processed, making them able to stay animated.