Skip to content

feat: Stop webp images from being processed to allow animated webp images#6060

Open
P4ncake4451 wants to merge 1 commit into
modrinth:mainfrom
P4ncake4451:main
Open

feat: Stop webp images from being processed to allow animated webp images#6060
P4ncake4451 wants to merge 1 commit into
modrinth:mainfrom
P4ncake4451:main

Conversation

@P4ncake4451
Copy link
Copy Markdown

@P4ncake4451 P4ncake4451 commented May 9, 2026

Webp images in the project galleries and icons are no longer being processed, making them able to stay animated.

This allows webp images to stay animated without being processed into the same format, also avoids processing the same format into the same format

Signed-off-by: P4ncake <76443059+P4ncake4451@users.noreply.github.com>
@modrinth-bot
Copy link
Copy Markdown
Member

Pull request changelog

App

Added

Changed

Deprecated

Removed

Fixed

Security

Website

Added

Changed

Deprecated

Removed

Fixed

Security

Hosting

Added

Changed

Deprecated

Removed

Fixed

Security

@P4ncake4451 P4ncake4451 changed the title Stop webp images from being processed into webp feat: Stop webp images from being processed to allow animated webp images May 9, 2026
@Prospector
Copy link
Copy Markdown
Member

this seems like it would also remove the resizing functionality, that should be kept

@P4ncake4451
Copy link
Copy Markdown
Author

this seems like it would also remove the resizing functionality, that should be kept

Why should gifs skip resizing though, that's what I don't understand

@Prospector
Copy link
Copy Markdown
Member

they really shouldn't be, sounds like a bug

@P4ncake4451
Copy link
Copy Markdown
Author

they really shouldn't be, sounds like a bug

It kidna looks like someone made a bandaid fix for gifs not animating after being processed, so they skipped processing them altogether, I've checked the script and if you disable that line which prevents gifs from being processed, it disables their animation after processing, despite webp supporting animation, same happened to animtated webps before

@Prospector
Copy link
Copy Markdown
Member

yeah, I think that is probably the case. ideally the resizing would be able to support animated ones too, but I understand if that's a little out of scope for what you wanted to do with this PR.

at least webp images will be smaller in size than a lot of other images, but I could still see this having a bandwidth impact if suddenly no webp images are downsized by default (though, I do not think that many people are uploading webp by default)

@P4ncake4451
Copy link
Copy Markdown
Author

Ideally gifs should also be converted to animated webps to save bandwidth, because the gif compression is horrible, but that'd need to come with animated webp support at the same time

@Prospector
Copy link
Copy Markdown
Member

yeah agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants