imp(core): Modify the entry value of the default setting to undefined…#372
Open
0x0a0d wants to merge 1 commit intomoleculerjs:masterfrom
Open
imp(core): Modify the entry value of the default setting to undefined…#3720x0a0d wants to merge 1 commit intomoleculerjs:masterfrom
0x0a0d wants to merge 1 commit intomoleculerjs:masterfrom
Conversation
… that permit its overwrite from other mixins.
Member
|
You can overwrite these values as well, just you should reorder the mixins |
Contributor
Author
|
I think it is better to change null to undefined. You can bump the minor version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Limitation in the
mergeSchemaSettingsfunction (service.js#L668), where the defaultmoleculer-dbsetting's entry value was set tonull, preventing it from being overridden by other mixins.By changing the default entry value to
undefined, it now aligns with Lodash’sdefaultsDeepmethod, which prioritizes values that are notundefined