fix terminal output to be consistent between scans#2235
Draft
Conversation
|
|
||
| // Build a mapping from CodeId to the query MRN used in the resolved policy. | ||
| // QueryMap() deduplicates by CodeId, so when multiple queries share the same | ||
| // compiled code (same CodeId) but have different MRNs, it may pick one whose |
There was a problem hiding this comment.
🔵 suggestion — buildCodeIdToMrnMap is called inside the for _, target := range report.RawResults loop (the outer loop starting around line 497), but its output depends only on resolved, which doesn't change per iteration. Consider hoisting this call above the outer loop to avoid rebuilding the map for every asset.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have inconsistent outputs when running cnspec scan local, this is only a visual bug, the correct results are still sent to server.