feat: Add AzureBlobStorage connection type support for private link s…#4366
feat: Add AzureBlobStorage connection type support for private link s…#4366christineschen wants to merge 8 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds Azure Blob Storage (AZURE_BLOB_STORAGE) as a supported vendor for mongodbatlas_stream_privatelink_endpoint (resource + data sources), including acceptance tests and documentation updates.
Changes:
- Added vendor constant + plan validation for Azure Blob Storage required fields (region, service endpoint ID, DNS domain).
- Added new Azure Blob Storage acceptance test coverage (private link endpoint + stream connection via PRIVATE_LINK).
- Updated generated schema docs and added Azure Blob Storage examples.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/testutil/acc/stream_privatelink_endpoint.go | Adds acceptance-test HCL config generator for Azure Blob Storage private link endpoint. |
| internal/testutil/acc/pre_check.go | Adds Azure credential precheck helpers for acceptance tests. |
| internal/service/streamprivatelinkendpoint/resource_test.go | Adds acceptance tests for Azure Blob Storage private link endpoint and required-field validation. |
| internal/service/streamprivatelinkendpoint/resource_schema.go | Updates schema Markdown descriptions to include AZURE_BLOB_STORAGE requirements. |
| internal/service/streamprivatelinkendpoint/model.go | Adds VendorAzureBlobStorage and required-field validation for Azure Blob Storage vendor. |
| internal/service/streamprivatelinkendpoint/model_test.go | Adds unit tests covering SDK<->TF model mapping and validation for Azure Blob Storage vendor. |
| internal/service/streamconnection/resource_stream_connection_test.go | Adds acceptance test for Azure Blob Storage stream connection using PRIVATE_LINK. |
| docs/resources/stream_privatelink_endpoint.md | Adds Azure Blob Storage example and updates schema docs text to include AZURE_BLOB_STORAGE. |
| docs/data-sources/stream_privatelink_endpoint.md | Adds Azure Blob Storage example and updates schema docs text to include AZURE_BLOB_STORAGE. |
| docs/data-sources/stream_privatelink_endpoints.md | Adds Azure Blob Storage example and updates schema docs text to include AZURE_BLOB_STORAGE. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
APIx bot: a message has been sent to Docs Slack channel |
lizo-mdb
left a comment
There was a problem hiding this comment.
LGTM with a couple of small suggestions.
🤖 Augment PR SummarySummary: Adds Azure Blob Storage ("AZURE_BLOB_STORAGE") support for Streams PrivateLink endpoints in the Atlas Terraform provider. Changes:
Technical Notes: Validation and examples codify the expected Azure Storage Account ARM ID and 🤖 Was this summary useful? React with 👍 or 👎 |
|
This PR has gone 7 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 7 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy! |
02eee4c to
5847aa7
Compare
osharaf-mdb
left a comment
There was a problem hiding this comment.
LGTM with a small formatting suggestion: if you wanted to use monospace, use backticks (`) instead of single quotes (')
| * AWS provider with CONFLUENT vendor. | ||
|
|
||
| * AZURE provider with EVENTHUB or CONFLUENT vendor. | ||
| * AZURE provider with EVENTHUB, CONFLUENT, or AZURE_BLOB_STORAGE vendor. For AZURE_BLOB_STORAGE, this should follow the format '{storageAccount}.blob.core.windows.net'. |
There was a problem hiding this comment.
If this is meant to be monospace, use backticks (`). Same applied throughout these changes.
| * AZURE provider with EVENTHUB, CONFLUENT, or AZURE_BLOB_STORAGE vendor. For AZURE_BLOB_STORAGE, this should follow the format '{storageAccount}.blob.core.windows.net'. | |
| * AZURE provider with EVENTHUB, CONFLUENT, or AZURE_BLOB_STORAGE vendor. For AZURE_BLOB_STORAGE, this should follow the format `{storageAccount}.blob.core.windows.net`. |
There was a problem hiding this comment.
I tried this and it seems to get errors because the doc generator converts backticks to single quotes so it comes across as an inconsistency
f069190 to
564563a
Compare
564563a to
a108140
Compare
…tream connections
Description
Adds support for
AZURE_BLOB_STORAGEas a vendor type inmongodbatlas_stream_privatelink_endpointresource and data sources.Link to any related issue(s): CLOUDP-383606
Type of change:
Required Checklist:
Further comments