Remove db_constraint on TranslatedField as translations are not unique#24812
Draft
diox wants to merge 5 commits into
Draft
Remove db_constraint on TranslatedField as translations are not unique#24812diox wants to merge 5 commits into
diox wants to merge 5 commits into
Conversation
We have been using this quirky "feature" of MySQL that allows FKs to point to non-unique rows in the translations app for 15+ years, but MySQL 8.4 raises an error unless --skip-restrict-fk-on-non-standard-key is set. This parameter is not supported on GCP, so remove the constraints instead.
diox
commented
May 13, 2026
| # Disable performance schema for faster startup | ||
| - --performance-schema=OFF | ||
| # Allow nonstandard FKs (needed for translations) | ||
| - --skip-restrict-fk-on-non-standard-key |
Member
Author
There was a problem hiding this comment.
#24894 proves just removing --skip-restrict-fk-on-non-standard-key in MySQL 8.4 without the changes from this PR loudly fails in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have been using this quirky "feature" of MySQL that allows FKs to point to non-unique rows in the translations app for 15+ years, but MySQL 8.4 raises an error unless
--skip-restrict-fk-on-non-standard-keyis set. This parameter is not supported on GCP, so remove the constraints instead.Unlocks mozilla/addons#15918