Skip to content

Fixed crash on close app #33899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Eism merged 2 commits into from
Jun 23, 2026
+3 −3
Merged

Fixed crash on close app #33899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a524e68
updated the framework
Eism Jun 22, 2026
0758141
delete palette score on context destroy, instead of init
Eism Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion muse
Open in desktop
Submodule muse updated 2 files
+4 −0 framework/global/internal/baseapplication.cpp
+1 −0 framework/global/modularity/imodulesetup.h
2 changes: 1 addition & 1 deletion src/engraving/engravingmodule.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ void EngravingContext::onInit(const muse::IApplication::RunMode&)
#endif
}

void EngravingContext::onDeinit()
void EngravingContext::onDestroy()
{
#ifndef ENGRAVING_NO_INTERNAL
m_paletteScoreProvider->deinit();
Expand Down
2 changes: 1 addition & 1 deletion src/engraving/engravingmodule.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ class EngravingContext : public muse::modularity::IContextSetup

void registerExports() override;
void onInit(const muse::IApplication::RunMode& mode) override;
void onDeinit() override;
void onDestroy() override;

private:

Expand Down
Loading