Skip to content

fix: Use default render target on polylineplot#107

Open
embarc-gabriel wants to merge 1 commit into
musescore:mainfrom
embarc-gabriel:opengl-conflict-when-open-effects
Open

fix: Use default render target on polylineplot#107
embarc-gabriel wants to merge 1 commit into
musescore:mainfrom
embarc-gabriel:opengl-conflict-when-open-effects

Conversation

@embarc-gabriel

Copy link
Copy Markdown
Contributor

Using FramebufferObject as render target conflicts with other UI elements when using shared opengl contexts.

Resolves: audacity/audacity#10753

  • I signed the CLA as username:
  • The title of the PR describes the problem it addresses.
  • Each commit's message describes its purpose and effects, and references the issue it resolves. If changes are extensive, there is a sequence of easily reviewable commits.
  • The code in the PR follows the coding rules.
  • I understand all aspects of the code I'm contributing and I'm able to explain it if requested.
  • The code compiles and runs on my machine, preferably after each commit individually. I have manually tested and verified that my changes fulfil their intended purpose.
  • No prior attempts to resolve this problem exist, or if they do, I listed them in my PR description and described how I avoided repeating past mistakes.
  • There are no unnecessary changes.
  • I created a unit test or vtest to verify the changes I made (if applicable).

Build configuration

audacity: audacity/audacity/master
audacity platforms: linux_x64
musescore: musescore/MuseScore/main
musescore platforms: linux_x64

Using framebuffer object as render target is conflicting with other
UI elements when using shared opengl contexts.
@embarc-gabriel embarc-gabriel changed the title fix: Use default render target image on polylineplot fix: Use default render target on polylineplot Jun 25, 2026
@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: c885dd39-8019-4e70-940e-8c43127a72b5

📥 Commits

Reviewing files that changed from the base of the PR and between 5468461 and f6e531b.

📒 Files selected for processing (1)
  • framework/uicomponents/qml/Muse/UiComponents/polylineplot.cpp
💤 Files with no reviewable changes (1)
  • framework/uicomponents/qml/Muse/UiComponents/polylineplot.cpp

📝 Walkthrough

Walkthrough

PolylinePlot’s constructor no longer calls setRenderTarget(QQuickPaintedItem::FramebufferObject). The remaining initialization, including antialiasing and setOpaquePainting(false), stays in place, so the render target selection now follows the default QQuickPaintedItem behavior.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Linked Issues check ❓ Inconclusive The change may address the reported crash, but the issue's LV2 interaction failure mode is not clearly evidenced here. Add a short explanation or test evidence showing how removing the framebuffer-object render target fixes issue #10753.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately describes the main change to PolylinePlot's render target.
Description check ✅ Passed The description includes the issue reference, motivation, checklist, and build config, so it is mostly complete.
Out of Scope Changes check ✅ Passed The patch is a single targeted render-target change with no unrelated code additions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LV2 Plugins realtime effects crash Audacity when interacting with project

2 participants