Skip to content

Add new accent colours and replace legacy ones#109

Open
ajuncosa wants to merge 1 commit into
musescore:mainfrom
ajuncosa:accent-colours
Open

Add new accent colours and replace legacy ones#109
ajuncosa wants to merge 1 commit into
musescore:mainfrom
ajuncosa:accent-colours

Conversation

@ajuncosa

@ajuncosa ajuncosa commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Resolves: #33863

Related to: musescore/MuseScore#33974

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

UiConfiguration::possibleAccentColors() now returns updated hardcoded accent color lists. The dark-mode list is expanded to more hex values, and the light-mode list is replaced with new values. The function still selects the dark list in dark mode and the light list otherwise.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ⚠️ Warning The PR description only links the issue and related PR, but it omits the required summary, motivation, and checklist from the template. Add a short change summary and motivation, then complete the required checklist items in the repository template.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: replacing legacy accent colours with new ones.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add more accent colours in Preferences

1 participant