ci: rotate ec2-github-runner SHA + opt into EBS encryption (Phase 6.b)#192
Merged
Conversation
namecheap/ec2-github-runner#27 merged. Rotates both pins from 0fdd401 (Phase 4 retry) to 7c6a9a7 (Phase 6.b) and flips the new encrypt-ebs input to 'true' so the acceptance-test runner's root volume launches with SSE-EBS. Risk: if the CI AWS account can't use the default aws/ebs KMS key or the shared AMI's snapshot is encrypted with a customer-managed key lacking a cross-account grant, start-runner will fail with a KMS / IAM error. The action-side code handles that gracefully (throws early rather than timing out on registration), so diagnostics are easy via aws ec2 get-console-output. If dogfood fails, revert just the encrypt-ebs line; SHA rotation is orthogonal and can stay green. Signed-off-by: yuriyryabikov <22548029+kurok@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #192 +/- ##
=======================================
Coverage 87.76% 87.76%
=======================================
Files 4 4
Lines 711 711
=======================================
Hits 624 624
Misses 52 52
Partials 35 35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dogfood rotation for namecheap/ec2-github-runner#27 (EBS encryption opt-in). Rotates both pins
0fdd401 → 7c6a9a7and setsencrypt-ebs: 'true'on the start-runner step.Risk: if this CI account can't use the default
alias/aws/ebsKMS key, or if the shared AMI's snapshot is encrypted under a customer-managed key lacking a cross-account grant,Start EC2 runnerwill fail with a KMS/IAM error. The action throws early (doesn't time out), so diagnostics are quick via the console-output recipe if needed.If it fails, the fix is a 1-line revert of the
encrypt-ebsinput — the SHA rotation itself is orthogonal and stays correct.