chore: Remove ensnode-react dependency#213
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThis PR removes the ChangesPackage Migration and Component Consolidation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR removes the
Confidence Score: 5/5Safe to merge — the change is a straightforward package consolidation with no logic modifications. Every changed file is an import-path update only; the same symbols are re-exported from @namehash/namehash-ui without any API changes. The author confirmed typecheck, lint, tests, and a visual Vercel preview all pass. Adding @tanstack/react-query as an explicit direct dep is correct given the updated peer-dependency contract in @namehash/namehash-ui@1.14.0. No files require special attention. The pnpm-lock.yaml carries a pre-existing transitive deprecation notice on @ungap/structured-clone@1.3.0 (not introduced by this PR). Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[ensawards.org app] --> B["@namehash/namehash-ui@1.14.0"]
A --> C["@ensnode/datasources@1.14.0"]
A --> D["@ensnode/ensnode-sdk@1.14.0"]
A --> E["@namehash/ens-referrals@1.14.0"]
A --> F["@tanstack/react-query@5.x (new direct dep)"]
B -->|peer dep satisfied by| F
B -->|exports formerly from ensnode-react| G["createEnsNodeProviderOptions\nEnsNodeProvider\nusePrimaryName\nuseRecords\nuseRegistrarActions\nASSUME_IMMUTABLE_QUERY"]
H["@ensnode/ensnode-react@1.11.1 (REMOVED)"] -.->|previously exported| G
style H fill:#ffcccc,stroke:#cc0000
Reviews (2): Last reviewed commit: "Update ENSNode packages to v1.14.0" | Re-trigger Greptile |
There was a problem hiding this comment.
Pull request overview
This PR migrates ENSAwards away from @ensnode/ensnode-react by importing the moved ENSNode React hooks/providers from @namehash/namehash-ui.
Changes:
- Removed
@ensnode/ensnode-reactand updated ENSNode/namehash package versions. - Updated React component imports for ENSNode providers/hooks.
- Removed
ensnode-reactreferences from ENS best-practice technical notes.
Reviewed changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
pnpm-lock.yaml |
Updates lockfile for dependency/version changes. |
package.json |
Updates root pnpm dependency overrides. |
ensawards.org/package.json |
Removes ensnode-react, updates ENSNode/namehash packages, and adds React Query peer dependency. |
ensawards.org/src/components/referral-awards-program/referrers/ReferrerLeaderboardSnippet.tsx |
Moves provider imports to @namehash/namehash-ui. |
ensawards.org/src/components/referral-awards-program/referrers/ReferrerLeaderboard.tsx |
Moves provider imports to @namehash/namehash-ui. |
ensawards.org/src/components/referral-awards-program/referrals/LiveReferralFeed.tsx |
Moves provider imports to @namehash/namehash-ui. |
ensawards.org/src/components/referral-awards-program/referrals/FetchAndDisplayRegistrarActionsFeed.tsx |
Moves useRegistrarActions import. |
ensawards.org/src/components/mocks/referrers-leaderboard/MockDisplayReferrerLeaderboardPage.tsx |
Moves mock provider imports. |
ensawards.org/src/components/mocks/referral-live-feed/MockDisplayRegistrarActionsFeed.tsx |
Moves mock provider imports. |
ensawards.org/src/components/ens-advocates/EnsAdvocateDetailsPageProvider.tsx |
Moves provider imports. |
ensawards.org/src/components/ens-advocates/details-page-components/FetchAndDisplayAdvocateReferrals.tsx |
Moves useRegistrarActions import. |
ensawards.org/src/components/ens-advocates/details-page-components/FetchAndDisplayAdvocateProfile.tsx |
Moves profile hook imports. |
ensawards.org/src/components/ens-advocates/details-page-components/advocate-profile/FetchAndDisplayAdvocateProfileWithName.tsx |
Moves records hook imports. |
ensawards.org/src/components/contract-naming-season/award-distributions/AwardDistributionsList.tsx |
Moves provider imports. |
ensawards.org/src/components/atoms/cards/ContributorsCard.tsx |
Consolidates identity/provider imports from @namehash/namehash-ui. |
ensawards.org/data/ens-best-practices/contract-naming/display-named-smart-contracts-mainnet.ts |
Removes ensnode-react from technical details. |
ensawards.org/data/ens-best-practices/contract-naming/display-named-smart-contracts-l2-chains.ts |
Removes ensnode-react from technical details. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
NOTEThe security vulnerability that Greptile mentions is not being surfaced by either |
lightwalker-eth
left a comment
There was a problem hiding this comment.
@Y3drk Looks nice! Please take the lead to merge when ready 👍
Lite PR → Remove
ensnode-reactdependencySummary
ensnode-reactdependency from ENSAwards after PR #2113 in ensnode got merged:ensawards.org/package.jsonand updated version of all ENSNode packages to0.0.0-next-20260518074131so that we can import the former ensnode-react hooks from thenamehash-uipackage, where they were temporarily movedensnode-reactfrom our best practice/benchmark details notes (although they will be reworked by PR feat: benchmark details refinement #204 in the near future)Why
Testing
typecheck,lint, andtestcommands locally to ensure that the migration didn't break anything, and later confirmed that in our CI workflowPre-Review Checklist (Blocking)