Skip to content

Update examples export to be published to NPM #2130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tk-o wants to merge 7 commits into from
Closed

Update examples export to be published to NPM #2130

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2ed324c
Update examples export to be published to NPM
tk-o May 18, 2026
e6413bb
Fix import paths
tk-o May 18, 2026
100fda5
Add specific package entrypoint for gql examples
tk-o May 18, 2026
6239a61
Update GQL examples
tk-o May 18, 2026
410e6ff
revert examples to use previous data model version
tk-o May 18, 2026
d5ce33d
publish the internal module for ENSNode SDK package
tk-o May 18, 2026
ca6540a
make name with resolver to be `demomigration.eth`
sevenzing May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions apps/ensadmin/src/app/api/omnigraph/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
import { useSearchParams } from "next/navigation";
import { useMemo } from "react";

import { getNamespaceSpecificValue } from "@ensnode/ensnode-sdk";
import { GRAPHQL_API_EXAMPLE_QUERIES } from "@ensnode/ensnode-sdk/internal";
import { GRAPHQL_API_EXAMPLE_QUERIES, getNamespaceSpecificValue } from "@ensnode/ensnode-sdk";
Comment thread
vercel[bot] marked this conversation as resolved.
Outdated
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 GRAPHQL_API_EXAMPLE_QUERIES not exported from main entry

GRAPHQL_API_EXAMPLE_QUERIES is imported from @ensnode/ensnode-sdk (the "." entry), but packages/ensnode-sdk/src/index.ts does not re-export it — it exports from ./omnigraph-api/prerequisites, not from ./omnigraph-api/example-queries. The new dedicated export path added in package.json is ./omnigraph-api/example-queries, so the correct import would be @ensnode/ensnode-sdk/omnigraph-api/example-queries. As written, this will fail to resolve at type-check and build time.


import { GraphiQLEditor } from "@/components/graphiql-editor";
import { RequireENSAdminFeature } from "@/components/require-ensadmin-feature";
Expand Down
2 changes: 1 addition & 1 deletion packages/ensnode-sdk/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export * from "./ensnode";
export * from "./ensrainbow";
export * from "./identity";
export * from "./indexing-status";
export * from "./omnigraph-api/prerequisites";
export * from "./omnigraph-api";
Comment thread
tk-o marked this conversation as resolved.
Outdated
Comment thread
tk-o marked this conversation as resolved.
Outdated
Comment thread
vercel[bot] marked this conversation as resolved.
Outdated
export * from "./registrars";
export * from "./resolution";
export * from "./shared/account-id";
Expand Down
2 changes: 2 additions & 0 deletions packages/ensnode-sdk/src/omnigraph-api/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
export * from "./example-queries";
export * from "./prerequisites";
3 changes: 2 additions & 1 deletion packages/ensnode-sdk/src/shared/datasource-contract.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ import {
type ENSNamespaceId,
maybeGetDatasource,
} from "@ensnode/datasources";
import { accountIdEqual } from "@ensnode/ensnode-sdk";

import { accountIdEqual } from "./account-id";

/**
* Gets the AccountId for the contract in the specified namespace, datasource, and
Expand Down
Loading