Skip to content

Feat/devnet to latest#2206

Merged
shrugs merged 1 commit into
mainfrom
feat/devnet-to-latest
May 26, 2026
Merged

Feat/devnet to latest#2206
shrugs merged 1 commit into
mainfrom
feat/devnet-to-latest

Conversation

@shrugs
Copy link
Copy Markdown
Member

@shrugs shrugs commented May 26, 2026

  • simple pr to update devnet to latest, little changed, only some addresses

Copilot AI review requested due to automatic review settings May 26, 2026 21:54
@shrugs shrugs requested a review from a team as a code owner May 26, 2026 21:54
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
admin.ensnode.io Ready Ready Preview, Comment May 26, 2026 9:59pm
enskit-react-example.ensnode.io Ready Ready Preview, Comment May 26, 2026 9:59pm
ensnode.io Ready Ready Preview, Comment May 26, 2026 9:59pm
ensrainbow.io Ready Ready Preview, Comment May 26, 2026 9:59pm

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 26, 2026

⚠️ No Changeset found

Latest commit: af6d27b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 26, 2026

Review Change Stack

Warning

Review limit reached

@shrugs, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 50 minutes and 59 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 50d1da04-165c-4a76-83b5-48df8f7d8faf

📥 Commits

Reviewing files that changed from the base of the PR and between 67c0aa0 and af6d27b.

📒 Files selected for processing (2)
  • docker/services/devnet.yml
  • packages/datasources/src/devnet/constants.ts
📝 Walkthrough

Walkthrough

This PR restructures ENS Subgraph documentation by migrating from /docs/integrate/subgraph/ to /docs/integrate/ens-subgraph/, adds comprehensive backwards-compatibility and key-limitations guides, updates routing and navigation configuration, removes legacy documentation pages, and updates related integration docs. It also includes devnet infrastructure updates.

Changes

Documentation Structure & Content Reorganization

Layer / File(s) Summary
Route and Navigation Configuration
docs/ensnode.io/astro.config.mjs, docs/ensnode.io/config/integrations/llms-txt.ts, docs/ensnode.io/config/integrations/starlight/sidebar-topics/integrate.ts, docs/ensnode.io/src/content/docs/docs/integrate/ens-subgraph/examples/index.mdx, docs/ensnode.io/src/content/docs/docs/integrate/ens-subgraph/schema-reference.mdx
Astro redirects, Starlight sidebar navigation, and LLMs.txt plugin configuration are updated to route /docs/integrate/subgraph/ paths to the new /docs/integrate/ens-subgraph/ structure and update internal documentation links accordingly.
New ENS Subgraph Documentation Pages
docs/ensnode.io/src/content/docs/docs/integrate/ens-subgraph/backwards-compatibility.mdx, docs/ensnode.io/src/content/docs/docs/integrate/ens-subgraph/examples/with-ensjs.mdx, docs/ensnode.io/src/content/docs/docs/integrate/ens-subgraph/index.mdx, docs/ensnode.io/src/content/docs/docs/integrate/ens-subgraph/key-limitations.mdx
Four new documentation pages added: backwards-compatibility guide (configuration via SUBGRAPH_COMPAT=true and querying patterns using stable node identifiers), key-limitations page (protocol-correctness gaps, data model limitations, missing ENSv2 support), overview describing legacy infrastructure and dependent applications, and ENSjs integration example with query patterns.
Integration Documentation Updates
docs/ensnode.io/src/content/docs/docs/integrate/ensv2-readiness.mdx, docs/ensnode.io/src/content/docs/docs/integrate/why-ensnode.mdx, docs/ensnode.io/src/content/docs/docs/services/ensapi/index.mdx
ENSv2 readiness documentation refactored from bullet lists to narrative paragraphs with link to key limitations, why-ensnode updated with CardGrid linking to subgraph limitations and protocol acceleration, and ENSApi docs enhanced with decentralization subsection.
Legacy Documentation Page Removals
docs/ensnode.io/src/content/docs/docs/integrate/subgraph/index.mdx, docs/ensnode.io/src/content/docs/docs/integrate/subgraph/examples/with-ensjs.mdx, docs/ensnode.io/src/content/docs/docs/integrate/subgraph/querying-best-practices.mdx, docs/ensnode.io/src/content/docs/docs/integrate/subgraph/subgraph-dependents.mdx
Four legacy documentation pages removed: old subgraph overview, previous ENSjs example, querying best practices, and dependent applications list—content consolidated into new ens-subgraph structure.

Infrastructure Updates

Layer / File(s) Summary
Devnet Configuration & Constants
docker/services/devnet.yml, packages/datasources/src/devnet/constants.ts, CLAUDE.md
Devnet service image updated to newer contracts-v2 tag (main-5677359); deterministic devnet contract addresses updated (PermissionedResolver, WrapperRegistryImpl, ApprovedUpgradeGate) and account fixtures (deployer, owner, user, user2) reassigned to new values; CLAUDE.md now points to AGENTS.md as a symbolic link.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related issues

  • namehash/ensnode#2138: Directly addresses the main objective of migrating from legacy ENS Subgraph documentation by updating the same docs sidebar configuration and subgraph-related pages.

Possibly related PRs

  • namehash/ensnode#2131: Both modify shared documentation pages (why-ensnode.mdx and ENSAPI overview) with overlapping content and section changes.
  • namehash/ensnode#2099: Both update ENSNode docs routing and navigation for Subgraph-related content via astro.config.mjs and Starlight sidebar configuration.
  • namehash/ensnode#1994: Both modify deterministic devnet contract and account constants that are used in devnet seeding and resolution tests.

Suggested labels

docs

Poem

🐰 A New Home for Subgraphs

The old paths shuffle to make room,
As legacy subgraphs find a new home,
Backwards compatibility blooms,
Key limitations mapped with care,
Newer docs point the way ahead—
ENSv2 ready, the ecosystem's spread! 🌱

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is severely incomplete, missing most required template sections (Why, Testing, Pre-Review Checklist) and provides only a vague one-liner. Complete the PR description following the template: add Why section with context/issues, Testing section with verification steps, and check the pre-review checklist items.
Title check ❓ Inconclusive The title is vague and generic; 'Feat/devnet to latest' doesn't convey meaningful specifics about what changed. Revise to be more descriptive, e.g., 'Update devnet contracts to latest version and refresh devnet constants' to better summarize the actual changes.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/devnet-to-latest

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the local ENS devnet configuration to match the latest contracts-v2 devnet image, and reorganizes/expands the documentation around the legacy ENS Subgraph integration (moving it under /docs/integrate/ens-subgraph with new pages and redirects).

Changes:

  • Bumps the devnet Docker image and updates the corresponding deterministic devnet contract/account addresses.
  • Restructures Subgraph integration docs into a new /integrate/ens-subgraph section, adding new “Key Limitations” and “Backwards Compatibility” pages and updating sidebar + redirects.
  • Updates integration/marketing docs to link to the new Subgraph docs and adds additional ENS Protocol Acceleration content.

Reviewed changes

Copilot reviewed 18 out of 20 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/datasources/src/devnet/constants.ts Updates devnet contract and named account “resolver” addresses; adds new contract entries.
docs/ensnode.io/src/content/docs/docs/services/ensapi/index.mdx Adds ENSAdminImage and new content under “ENS Protocol Acceleration”.
docs/ensnode.io/src/content/docs/docs/integrate/why-ensnode.mdx Reworks “Why it matters” section to link to new Subgraph limitation docs and adds an ecosystem adoption list.
docs/ensnode.io/src/content/docs/docs/integrate/subgraph/subgraph-dependents.mdx Removes old page (content migrated into new ens-subgraph overview).
docs/ensnode.io/src/content/docs/docs/integrate/subgraph/querying-best-practices.mdx Removes old page (guidance moved into backwards-compatibility page).
docs/ensnode.io/src/content/docs/docs/integrate/subgraph/index.mdx Removes old overview page (replaced by new ens-subgraph overview).
docs/ensnode.io/src/content/docs/docs/integrate/subgraph/examples/with-ensjs.mdx Removes old example page (re-added under new path).
docs/ensnode.io/src/content/docs/docs/integrate/ensv2-readiness.mdx Condenses historical limitations section; adds links to new Subgraph limitations + Protocol Acceleration anchor.
docs/ensnode.io/src/content/docs/docs/integrate/ens-subgraph/schema-reference.mdx Updates links to new ens-subgraph paths.
docs/ensnode.io/src/content/docs/docs/integrate/ens-subgraph/key-limitations.mdx Adds new “Key Limitations” page.
docs/ensnode.io/src/content/docs/docs/integrate/ens-subgraph/index.mdx Adds new Subgraph overview page including usage metrics and dependents list.
docs/ensnode.io/src/content/docs/docs/integrate/ens-subgraph/examples/with-viem.mdx Adds new viem Chain configuration example page.
docs/ensnode.io/src/content/docs/docs/integrate/ens-subgraph/examples/with-ensjs.mdx Adds new ENSjs integration guide and well-known query references.
docs/ensnode.io/src/content/docs/docs/integrate/ens-subgraph/examples/index.mdx Updates example links to new ens-subgraph paths.
docs/ensnode.io/src/content/docs/docs/integrate/ens-subgraph/backwards-compatibility.mdx Adds new backwards-compatibility + querying guidance page.
docs/ensnode.io/config/integrations/starlight/sidebar-topics/integrate.ts Updates Integrate sidebar to point at new ens-subgraph pages.
docs/ensnode.io/config/integrations/llms-txt.ts Updates llms-txt generation paths for moved schema reference.
docs/ensnode.io/astro.config.mjs Adds redirects from old subgraph doc paths to new ens-subgraph paths.
docker/services/devnet.yml Bumps devnet image tag to a newer contracts-v2 build.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 26, 2026

Greptile Summary

This PR bumps the devnet Docker image to the latest contracts-v2 commit and updates the corresponding on-chain addresses in the datasources constants file to match.

  • Docker image tag updated from main-580c60a to main-5677359; the service configuration is otherwise unchanged.
  • In constants.ts, the PermissionedResolver address is updated, WrapperRegistry is renamed to WrapperRegistryImpl (no other TypeScript files reference the old key), a new ApprovedUpgradeGate contract is added, and all four named-account resolver addresses are refreshed to match the new deployment.

Confidence Score: 5/5

This PR is safe to merge — it is a straightforward update of devnet image tag and matching contract/account addresses with no logic changes.

Both changed files are purely configuration: the Docker image tag is bumped and the deterministic devnet addresses are updated to match the new deployment. The renamed key WrapperRegistryImpl (previously WrapperRegistry) has no other consumers in the TypeScript codebase, so there is no silent breakage. The new ApprovedUpgradeGate entry is additive. No business logic, auth, or data-handling code is touched.

No files require special attention.

Important Files Changed

Filename Overview
docker/services/devnet.yml Docker image tag bumped from main-580c60a to main-5677359 for the ENS contracts-v2 devnet; no structural changes.
packages/datasources/src/devnet/constants.ts Updated contract addresses for the new devnet image: PermissionedResolver address changed, WrapperRegistry renamed to WrapperRegistryImpl, new ApprovedUpgradeGate contract added, and all four named account resolver addresses updated to match the new deployment.

Sequence Diagram

sequenceDiagram
    participant Dev as Developer / CI
    participant Docker as Docker Compose
    participant Devnet as contracts-v2 Devnet (Anvil)
    participant ENSNode as ENSNode (datasources)

    Dev->>Docker: docker compose up devnet
    Docker->>Devnet: pull ghcr.io/ensdomains/contracts-v2:main-5677359
    Devnet-->>Docker: container healthy (port 8545)
    Docker-->>Dev: devnet ready

    Dev->>ENSNode: start ENSNode against devnet
    ENSNode->>Devnet: resolve contracts via constants.ts addresses
    Note over ENSNode,Devnet: PermissionedResolver → 0x8550d3…<br/>ApprovedUpgradeGate → 0x4c4a2f…<br/>WrapperRegistryImpl → 0xd8a5a9…
    Devnet-->>ENSNode: on-chain data
Loading

Reviews (2): Last reviewed commit: "deps: devnet to latest with constants bu..." | Re-trigger Greptile

Copy link
Copy Markdown
Contributor

@vercel vercel Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Suggestion:

Broken internal link in with-viem.mdx pointing to old documentation path structure after ENS Subgraph documentation restructuring

Fix on Vercel

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/ensnode.io/src/content/docs/docs/integrate/why-ensnode.mdx`:
- Line 109: The list item "**[pier](https://github.com/Quantumlyy/pier)**" is
missing terminal punctuation; edit that markdown list entry to add a period at
the end (make it "**[pier](https://github.com/Quantumlyy/pier)**.") so it
matches the documentation style and other list items.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 4542fe68-41b6-4fcd-bda8-294a6b5d027c

📥 Commits

Reviewing files that changed from the base of the PR and between 153ae0e and 67c0aa0.

📒 Files selected for processing (20)
  • CLAUDE.md
  • docker/services/devnet.yml
  • docs/ensnode.io/astro.config.mjs
  • docs/ensnode.io/config/integrations/llms-txt.ts
  • docs/ensnode.io/config/integrations/starlight/sidebar-topics/integrate.ts
  • docs/ensnode.io/src/content/docs/docs/integrate/ens-subgraph/backwards-compatibility.mdx
  • docs/ensnode.io/src/content/docs/docs/integrate/ens-subgraph/examples/index.mdx
  • docs/ensnode.io/src/content/docs/docs/integrate/ens-subgraph/examples/with-ensjs.mdx
  • docs/ensnode.io/src/content/docs/docs/integrate/ens-subgraph/examples/with-viem.mdx
  • docs/ensnode.io/src/content/docs/docs/integrate/ens-subgraph/index.mdx
  • docs/ensnode.io/src/content/docs/docs/integrate/ens-subgraph/key-limitations.mdx
  • docs/ensnode.io/src/content/docs/docs/integrate/ens-subgraph/schema-reference.mdx
  • docs/ensnode.io/src/content/docs/docs/integrate/ensv2-readiness.mdx
  • docs/ensnode.io/src/content/docs/docs/integrate/subgraph/examples/with-ensjs.mdx
  • docs/ensnode.io/src/content/docs/docs/integrate/subgraph/index.mdx
  • docs/ensnode.io/src/content/docs/docs/integrate/subgraph/querying-best-practices.mdx
  • docs/ensnode.io/src/content/docs/docs/integrate/subgraph/subgraph-dependents.mdx
  • docs/ensnode.io/src/content/docs/docs/integrate/why-ensnode.mdx
  • docs/ensnode.io/src/content/docs/docs/services/ensapi/index.mdx
  • packages/datasources/src/devnet/constants.ts
💤 Files with no reviewable changes (4)
  • docs/ensnode.io/src/content/docs/docs/integrate/subgraph/examples/with-ensjs.mdx
  • docs/ensnode.io/src/content/docs/docs/integrate/subgraph/subgraph-dependents.mdx
  • docs/ensnode.io/src/content/docs/docs/integrate/subgraph/index.mdx
  • docs/ensnode.io/src/content/docs/docs/integrate/subgraph/querying-best-practices.mdx

Comment thread docs/ensnode.io/src/content/docs/docs/integrate/why-ensnode.mdx Outdated
@shrugs shrugs merged commit 9fdd2d5 into main May 26, 2026
20 checks passed
@shrugs shrugs deleted the feat/devnet-to-latest branch May 26, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants