Skip to content

HeapBlock Convert now honours unsigned parameter #3350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josesimoes merged 1 commit into from
May 8, 2026
Merged

HeapBlock Convert now honours unsigned parameter #3350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions src/CLR/Include/nanoCLR_Runtime__HeapBlock.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1354,6 +1354,29 @@ struct CLR_RT_HeapBlock
//
// For V1, we don't throw on overflow.
//
// For conv.r.un, the source must be treated as unsigned regardless of its
// declared DataType (which is always a signed type on the eval stack).
// Remap to the unsigned equivalent so Convert_Internal selects scaleIn = -1.
if (fUnsigned)
{
switch (DataType())
{
case DATATYPE_I1:
ChangeDataType(DATATYPE_U1);
break;
case DATATYPE_I2:
ChangeDataType(DATATYPE_U2);
break;
case DATATYPE_I4:
ChangeDataType(DATATYPE_U4);
break;
case DATATYPE_I8:
ChangeDataType(DATATYPE_U8);
break;
default:
break;
}
}
return Convert_Internal(et);
}

Expand Down