Skip to content

Support array values in custom attribute parser#3352

Merged
josesimoes merged 1 commit into
nanoframework:developfrom
josesimoes:fix-attribute-parsing
May 11, 2026
Merged

Support array values in custom attribute parser#3352
josesimoes merged 1 commit into
nanoframework:developfrom
josesimoes:fix-attribute-parsing

Conversation

@josesimoes
Copy link
Copy Markdown
Member

Description

  • Add parsing for SZARRAY custom attribute arguments and validate mapped element types before lookup. This keeps nanoCLR aligned with MDP’s proprietary attribute encoding for DataRow arguments such as byte[].

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dev Containers (changes related with Dev Containers, has no impact on code or features)
  • Dependencies/declarations (update dependencies or assembly declarations and changes associated, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).

- Add parsing for SZARRAY custom attribute arguments and validate mapped element types before lookup. This keeps nanoCLR aligned with MDP’s proprietary attribute encoding for DataRow arguments such as byte[].
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 11, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 5e08bc6d-46b6-4897-b971-1f951d71bfdf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@josesimoes josesimoes merged commit 5546446 into nanoframework:develop May 11, 2026
23 checks passed
@josesimoes josesimoes deleted the fix-attribute-parsing branch May 11, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants