Skip to content

Remove ids constraint on delete relationship via CUD #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stfnzl wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove ids constraint on delete relationship via CUD #475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions sink/src/main/kotlin/org/neo4j/connectors/kafka/sink/strategy/cud/DeleteRelationship.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,6 @@ data class DeleteRelationship(
)
}

if (start.ids.isEmpty() || end.ids.isEmpty()) {
throw InvalidDataException(
"'${Keys.FROM}' and '${Keys.TO}' must contain at least one ID property."
)
}

val startParam = Cypher.parameter("start")
val endParam = Cypher.parameter("end")
val keysParam = Cypher.parameter("keys")
Expand Down
51 changes: 51 additions & 0 deletions sink/src/test/kotlin/org/neo4j/connectors/kafka/sink/strategy/CudHandlerTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -857,6 +857,57 @@ class CudHandlerTest : HandlerTest() {
)
}

@Test
fun `should delete relationship without constraint on 'from' or 'to'`() {
val handler = CudHandler("my-topic", Renderer.getDefaultRenderer(), 100)

val sinkMessage =
newMessage(
Schema.STRING_SCHEMA,
"""
{
"type": "relationship",
"op": "DELETE",
"rel_type": "RELATED_TO",
"from": {
"labels": ["Foo"],
"ids": {}
},
"to": {
"labels": ["Bar"],
"ids": {}
}
}
""",
)
handler.handle(listOf(sinkMessage)) shouldBe
listOf(
listOf(
ChangeQuery(
null,
null,
listOf(sinkMessage),
Query(
CypherParser.parse(
"""
MATCH (start:`Foo` {}) WITH start
MATCH (end:`Bar` {}) WITH start, end
MATCH (start)-[r:`RELATED_TO` {}]->(end)
DELETE r
"""
)
.cypher,
mapOf(
"start" to mapOf("keys" to emptyMap<String, Any?>()),
"end" to mapOf("keys" to emptyMap()),
"keys" to emptyMap()
),
),
)
)
)
}

@ParameterizedTest
@ValueSource(ints = [1, 6, 25, 100])
fun `should support mixed operations with different batch sizes`(batchSize: Int) {
Expand Down