feat: use sink action abstraction in pattern handlers#570
Open
feat: use sink action abstraction in pattern handlers#570
Conversation
Co-authored-by: Erik Nord <erik.nord@neo4j.com> Co-authored-by: Vasif Abdulhamidov <vasif.abdulhamidov@neo4j.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the Kafka sink pattern strategy implementation by replacing the legacy
NodePatternHandlerandRelationshipPatternHandlerclasses with newNodePatternEventTransformerandRelationshipPatternEventTransformerclasses. The changes update the handler creation logic, imports, and related tests to use the new event transformer classes, and remove the old handler classes entirely.This makes the pattern handlers also support exactly-once semantics and the recently introduced batching strategies.
Resolves CONN-746.