chore(deps): bump k8s.io/klog/v2 from v2.130.1 to v2.140.0

[pierluigilenoci]

Summary

Bumps k8s.io/klog/v2 from v2.130.1 to v2.140.0 in both operators/ and infrastructure/ingress-controller/custom-error-pages/.

Changes

• operators/go.mod / operators/go.sum — klog v2.130.1 → v2.140.0
• infrastructure/ingress-controller/custom-error-pages/go.mod / go.sum — klog v2.130.1 → v2.140.0

[kingmakerbot]

Hi @pierluigilenoci. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

• /rebase: Rebase this PR onto the master branch
• /merge: Merge this PR into the master branch
• /hold: Adds hold label to prevent merging with /merge
• /unhold: Removes the hold label to allow merging with /merge
• /deploy-staging: Deploy a staging environment to test this PR (the build-all flag enables user environments building)
• /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

• kind/breaking: 💥 Breaking Change
• kind/feature: 🚀 New Feature
• kind/bug: 🐛 Bug Fix
• kind/cleanup: 🧹 Code Refactoring
• kind/docs: 📝 Documentation

[QcFe]

Hi @pierluigilenoci, thanks for your contribution.
Unfortunately several tests aren't passing, as you may have noticed. Apart from having removed a couple of rather crucial directives without which the applications you touched can't start, changes like these would also require changes to the associated helm charts. Also whenever go linting checks are explicitly disabled, we generally require a comment to explain the reason why they have been.

[pierluigilenoci]

Hi @QcFe, thanks for the review! You're absolutely right — I'm sorry about the broken state.

I've pushed a fix (62f8e4b) that addresses all the issues you raised:

Restored accidentally deleted directives:

• bastion-operator/main.go: restored the ctrl.NewManager(...) call that was removed
• instance-automation/main.go: restored ctrl.SetLogger(...), log := ctrl.Log.WithName("setup"), and whiteListMap := parseMap(...) — without these the application can't start
• instance-operator/main.go: restored ctrl.SetLogger(textlogger.NewLogger(textlogger.NewConfig()))
• instmetrics/main.go: restored log := textlogger.NewLogger(textlogger.NewConfig()).WithName("instmetrics")
• operator/main.go: restored the // Set the ctrl.Log to klogr comment
• examagent/options.go: restored the // Parse and normalize options. doc comment
• custom-error-pages/server/main.go: restored the // Load response templates comment

Added explanatory nolint comments:
All //nolint:errcheck directives now include a reason: // flag is registered by klog.InitFlags above

Regarding helm chart changes: The flag.Set() calls set defaults before flag.Parse(), so any --stderrthreshold=... passed via helm chart args will override the code defaults. If you'd prefer explicit helm chart values for these flags, happy to add them — please let me know.

Thanks again for catching these!

[QcFe]

Ciao @pierluigilenoci, sorry for getting back to you this late. We eventually considered we don't mind the new behavior and that we prefer not to have the flags to revert to the old standard. So bumping dependencies would be enough already :)

[pierluigilenoci]

Thanks @QcFe! Understood — I've simplified the PR to just the klog dependency bump (v2.130.1 → v2.140.0) without the stderrthreshold behavior flags.

[QcFe]

/deploy-staging

[kingmakerbot]

Your staging environment has been correctly deployed.
You can access the application frontend and Qlkube APIs using the following URLs:

• Frontend: https://1101.staging.ng.crownlabs.polito.it/app
• Qlkube GraphQL API: https://graphql.1101.staging.ng.crownlabs.polito.it/
  Operators: possibly add the crownlabs.polito.it/operator-selector=staging-1101 label to desired tenants.

[kingmakerbot]

Your staging environment has been correctly teared down.