Skip to content

fixes #1252 problem with additionalProperties schema in jsconfig schema#1253

Merged
stevehu merged 1 commit into
masterfrom
issue1252
Jun 21, 2026
Merged

fixes #1252 problem with additionalProperties schema in jsconfig schema#1253
stevehu merged 1 commit into
masterfrom
issue1252

Conversation

@stevehu

@stevehu stevehu commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@stevehu stevehu requested a review from justin-tay June 20, 2026 22:28

@justin-tay justin-tay left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think the lines for skipping the context items were there since the initial commit and was never really sure what use case they were for. Don't really see an issue with removing it.

@stevehu stevehu merged commit 096fbfd into master Jun 21, 2026
3 checks passed
@stevehu stevehu deleted the issue1252 branch June 21, 2026 11:59
stevehu added a commit that referenced this pull request Jun 21, 2026
* fixes #1248 validating draft4 schemas (#1249)

* fixes #1248 validating draft4 schemas

* Address regex factory review comments

* Rename regex specification version variable

* fixes #1174 TextNodes as schema seem to validate any value (#1250)

* fixes #1174 TextNodes as schema seem to validate any value

* Address loaded schema validation for issue 1174

* Address schema node validation review comments

* Preserve mapped schema override path

* Validate referenced document fragment schemas

* Remove duplicate schema type validation

* Validate loaded schemas for anchor refs

* fixes #1252 problem with additionalProperties schema in jsconfig schema (#1253)

* Add method to SpecificationVersion to determine from schema node (#1221)

* Manual adjustments for Jackson 2 compatibility and CVE fix

---------

Co-authored-by: Justin Tay <49700559+justin-tay@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants