simplify additionalItems validation flow#1256
Merged
stevehu merged 1 commit intoJun 22, 2026
Merged
Conversation
Contributor
|
@Oz-er Thanks a lot for your help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simplifies the
additionalItemshandling inItemsLegacyValidatorby removing an empty branch that containedonly commented-out code.
Rationale
PMD reported an
EmptyControlStatementin this area. The previousif (this.additionalItems)branch had noactive behavior, while the
elsebranch handled the validation error case. This change checksif (! this.additionalItems)directly and preserves the existing behavior.Related issue: #ISSUE_NUMBER
Validation
EmptyControlStatementfinding is removedmvn testmvn verify