Skip to content

ci(dependabot): bring back Nextcloud command approve #8462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ShGKme merged 1 commit into from
Apr 23, 2026
+7 −0
Merged

ci(dependabot): bring back Nextcloud command approve #8462

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/dependabot-approve-merge.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,13 @@ jobs:
with:
github-token: ${{ secrets.GITHUB_TOKEN }}

# Nextcloud bot approve
- name: Nextcloud Bot approve
uses: hmarr/auto-approve-action@f0939ea97e9205ef24d872e76833fa908a770363 # v4.0.0
if: startsWith(steps.branchname.outputs.branch, 'dependabot/')
with:
github-token: ${{ secrets.DEPENDABOT_AUTOMERGE_TOKEN }}
Comment on lines +53 to +58
Copy link
Copy Markdown
Contributor

@susnux susnux Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But then this should be part of the templates.
It is not - I guess its replaced with the bot approval directly above this?

Copy link
Copy Markdown
Contributor

@Antreesy Antreesy Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Library requires two approvals, maybe that was the reason for duplication?

Copy link
Copy Markdown
Contributor

@susnux susnux Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes this one requires two (most only one).
Not sure when it got removed but its in upstream templates, so should also be added back to library templates:

nextcloud-libraries/.github#150

Copy link
Copy Markdown
Contributor Author

@ShGKme ShGKme Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need it in a template, if this is only needed in this repo?


# Enable GitHub auto merge
- name: Auto merge
uses: alexwilson/enable-github-automerge-action@56e3117d1ae1540309dc8f7a9f2825bc3c5f06ff # v2.0.0
Expand Down
Loading