fix(browser): resolve context canceled errors on Windows#1168
Open
egany wants to merge 1 commit into
Open
Conversation
Root cause: Browser object was bound to a short-lived connect context that expired after Start() returned, causing all subsequent operations to fail instantly with context canceled. Changes: - Use goroutine + channel for connect timeout instead of binding context - Add Microsoft Edge auto-detection as fallback browser - Add isolated user data directory to avoid profile conflicts - Add leakless config option (disabled by default on Windows) - Change WaitStable to WaitLoad for more reliable page loading - Add Windows troubleshooting documentation Tested on Windows 10 Pro with Edge, successfully loads vnexpress.net.
egany
force-pushed
the
fix/browser-tool-windows-context-handling
branch
from
1cecfb6 to
23affa2
Compare
mrgoonie
requested changes
Jun 25, 2026
mrgoonie
left a comment
mrgoonie
left a comment
Contributor
There was a problem hiding this comment.
Summary: I reviewed this Windows browser context-canceled fix. The root-cause direction is valid, but this PR is not mergeable yet and has one implementation issue that should be fixed before merge.
Findings:
- Important: The PR is currently merge-conflicted (
mergeStateStatus=DIRTY) and has no reported CI checks on the branch, so it cannot be merged from the bounded maintainer lane. - Important:
pkg/browser/browser.gonow uses a fixed profile path underos.TempDir()/goclaw-browser-profilefor every local browser launch. That creates cross-run/profile lock contention and can leak cookies/session state between browser manager restarts. Please use a per-manager/per-process temp directory and clean it up with the launcher lifecycle, or let rod/launcher create an isolated profile.
Gates:
- Duplicate/prior implementation: no duplicate PR/issue found for this exact Windows context-canceled fix.
- Project standards: existing browser manager structure found; the fix is in the right area.
- Strategic necessity: clear value, especially given related browser-context-canceled reports.
Verdict: Request changes. Resolve conflicts, restore CI, and replace the global user-data-dir with an isolated lifecycle-scoped profile before this can be approved.
mrgoonie
added
agent:github-maintain
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
context cancelederrors on WindowsStart()returnedChanges
pkg/browser/browser.gopkg/browser/browser_tabs.gopkg/browser/browser_page.gocmd/gateway_setup.gointernal/config/config_channels.godocs/browser-tool-windows-troubleshooting.mdAGENTS.mdTest Plan
context cancelederrors