Skip to content

Improve Makefile documentation for command flag handling #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shashank2125 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve Makefile documentation for command flag handling #377

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,16 @@ SHELL := /usr/bin/env bash
IMAGE := igel
VERSION := latest

#! An ugly hack to create individual flags
#-----------------------------------------------------------------------
#Conditional configuration for tool command flags
#
#When STRICT=1, all tools run in strict mode(no dash prefix)
#When STRICT is unset, dash-prefixed flags(-) are used to disable strict checks
#This approach ensures comaptibility across Poetry, Pip, Safety, Bandit, and other tools.
#
#Note: Make does not support dynamic variable creation in a portable way,
#so flags are defined explicitly below clarity
#------------------------------------------------------------------------
ifeq ($(STRICT), 1)
POETRY_COMMAND_FLAG =
PIP_COMMAND_FLAG =
Expand Down