Enable TLS-PSK auth#316
Conversation
essen
left a comment
There was a problem hiding this comment.
Please add test(s) to acceptor_SUITE. You can make it look similar to the SNI tests.
|
@essen Thanks for review and your comments. I've made alphabetical order for options and added two tests for PSK. |
|
@juhlig @Maria-12648430 Can you please review? Thanks! |
|
Oh... I never noticed the review request =^^= SSL/TLS is really not my home ground, but in any case, the tests on buildkite mostly failed in just the tests added by this PR, so... |
|
@Maria-12648430 I think merging this wouldn't be a problem for #324 (minus a potential rebase), since we move forward when the option is there, and if using TLS 1.3 we then reject the option. Correct? |
Hm, I'm not sure. There is some kind of clash here, yes. If the |
|
Right we remove not reject. So we would end up with a potentially confusing error then I think. But I'm not sure we should do anything about it. |
|
I have no idea what would happen if |
The possible outcomes for
|
|
OK good enough. |
|
Merged, thanks! |
If we need only TLS-PSK authentication (without additional certificates, sni, etc) cowboy returns
{error, no_cert}forcowboy:start_tls/3. Actually this is regular way to use PSK, althouht it's rare.Sample config for this case: