nsqd: add opt-in --http-reject-chunked flag to reject chunked requests#1516
Open
shipra-gupta-2000 wants to merge 1 commit into
Open
nsqd: add opt-in --http-reject-chunked flag to reject chunked requests#1516shipra-gupta-2000 wants to merge 1 commit into
shipra-gupta-2000 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavior : when HTTPRejectChunked is true, doPUB and doMPUB return 400 for chunked requests.
Provides operators a safe, non-breaking way to opt in to stricter HTTP handling (reject chunked requests) without changing default behavior or breaking existing clients. Helps fail early for clients that must avoid chunked bodies.
It replaces the TODO
// TODO: one day I'd really like to just error on chunked requests
// to be able to fail "too big" requests before we even read