Modernize project tooling, CI, and example apps#391
Open
usama-liaqat wants to merge 3 commits intonumandev1:mainfrom
Open
Modernize project tooling, CI, and example apps#391usama-liaqat wants to merge 3 commits intonumandev1:mainfrom
usama-liaqat wants to merge 3 commits intonumandev1:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The project's tooling, CI pipelines, and example apps were outdated — Yarn Classic (v1), Node 10 Docker images, JDK 11, Ruby 2.7, deprecated GitHub Actions (v2), and a single
example/directory tied to an older React Native version. This PRmodernizes everything to align with the current ecosystem and replaces the monolithic
example/andexampleExpo/directories with a cleanexamples/bare/andexamples/expo/workspace structure.Changelog
[General] [Changed]- Migrated from Yarn Classic to Yarn Berry 4.14.1 with workspaces consolidated toexamples/*[General] [Changed]- Replacedexample/andexampleExpo/withexamples/bare/(React Native 0.85.2) andexamples/expo/(React Native 0.81.5 via Expo SDK)[General] [Changed]- Modernizedtsconfig.json(jsx: react-jsx,moduleResolution: bundler, scopedincludetosrc/)[General] [Added]- Addedsrc/global.d.tsto typeAbortSignal.addEventListener/removeEventListenerwithout requiring full DOM lib[CI] [Changed]- Updated CircleCI Docker image from deprecatedcircleci/node:10tocimg/node:22.11[CI] [Changed]- Fixed CircleCI script references (typescript→typecheck,prepare→prepack)[CI] [Changed]- Updated all GitHub Actions to latest versions (checkout@v4,setup-java@v4,cache@v4,stale@v9)[CI] [Changed]- Updated JDK 11 → 17, Ruby 2.7 → 3.2, Xcode simulator iPhone 11 Pro → iPhone 15 Pro[CI] [Changed]- Updated all path references fromexample/toexamples/bare/andexamples/expo/[CI] [Changed]- Replacedyarn install --frozen-lockfilewithyarn install --immutableacross all workflows[CI] [Changed]- Updated branch triggers frommastertomain[CI] [Removed]- Removed manual yarn cache steps (Yarn Berry handles caching natively)[CI] [Removed]- Removed deprecated.github/stale.yml(probot-stale), already replaced bystale-bot.ymlworkflow usingactions/stale@v9[Docs] [Changed]- UpdatedCONTRIBUTING.mdwith new paths, scripts (yarn example:bare,yarn example:expo), and removed obsolete new-arch toggle instructionsTest Plan
yarn installcompletes successfullyyarn typecheckpasses with zero errorsyarn lintpassesyarn example:bare androidbuilds and runs on device/emulator (React Native 0.85.2)yarn example:bare iosbuilds and runs on simulator (React Native 0.85.2)yarn example:expo startlaunches the Expo dev server (React Native 0.81.5)